Create subcommand for getting demo data #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, just use the existing test image registry. A future commit will switch to using some mouse data.
naglepuff
force-pushed
the
190-public-demo
branch
from
c2c0ca0 to
0621008
Compare
|
@naglepuff This is excellent. |
manthey
reviewed
Dec 10, 2024
docs/demo.md
Outdated
| This will create a new directory in the location it is run called `demo_files` and download several whole slide images into that directory. These images contain fake PHI, which we will redact with Image DePHI. | ||
|
|
||
| ## Redacting with the Graphical User Interface (GUI) | ||
| Image DePHI allows redaction of whole slide images through either a graphical user interface, accessible through a web browser, or a command line interface. First, let's take a look at the readaction workflow using the graphical user interface. |
docs/demo.md
Outdated
|
|
||
| ## Getting the demo data | ||
|
|
||
| In order to get the demo data, you will need to have installed Image DePHI and run the following command: |
There was a problem hiding this comment.
Elsewhere we use "ImageDePHI" as a single word. I think I prefer that to having the space between Image and DePHI.
manthey
reviewed
Dec 10, 2024
imagedephi/main.py
Outdated
| hash = row["hash"] | ||
| algo, hash_value = hash.split(":") | ||
| pooch.retrieve( | ||
| url=f"http://data.kitware.com/api/v1/file/hashsum/{algo}/{hash_value}/download", |
manthey
approved these changes
Dec 10, 2024
naglepuff
force-pushed
the
190-public-demo
branch
from
21e0740 to
e698b5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Image DePHI demo.
Fix #190
Changes
1. New Subcommand
The new command
imagedephi demo-datawill parse the new filedemo_files.csvand use pooch to download the files from DKC if you don't have that already.2. Demo walkthrough
Instructions on using both the Image DePHI GUI and CLI are included under
/docs. There's also a link from the README.For Reviewers
Please make sure the new subcommand works and you can acquire the demo data. Also follow along with the walkthrough and provide feedback on clarity, coherence, etc.