split temp_code into two arrays

Dillonb · Sep 15, 2024 · b4aeed1 · b4aeed1
1 parent c1fb56b
commit b4aeed1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 18 deletions.
diff --git a/src/cpu/dynarec/v2/v2_compiler.c b/src/cpu/dynarec/v2/v2_compiler.c
@@ -1,5 +1,6 @@
 #include "v2_compiler.h"
 
+#include <dynarec/dynarec.h>
 #include <log.h>
 #include <mem/n64bus.h>
 #include <disassemble.h>
@@ -41,10 +42,11 @@ bool should_break(u32 address) {
 static bool v2_idle_loop_detection_enabled = true;
 
 int temp_code_len = 0;
-source_instruction_t temp_code[TEMP_CODE_SIZE];
+mips_instruction_t temp_code[TEMP_CODE_SIZE];
+dynarec_instruction_category_t temp_code_category[TEMP_CODE_SIZE];
 u64 temp_code_vaddr = 0;
 
-#define LAST_INSTR_CATEGORY (temp_code[temp_code_len - 1].category)
+#define LAST_INSTR_CATEGORY (temp_code_category[temp_code_len - 1])
 #define LAST_INSTR_IS_BRANCH ((temp_code_len > 0) && ((LAST_INSTR_CATEGORY == BRANCH) || (LAST_INSTR_CATEGORY == BRANCH_LIKELY)))
 
 u64 v2_get_last_compiled_block() {
@@ -68,18 +70,18 @@ void fill_temp_code(u64 virtual_address, u32 physical_address, bool* code_mask)
 
         dynarec_instruction_category_t prev_instr_category = NORMAL;
         if (i > 0) {
-            prev_instr_category = temp_code[i - 1].category;
+            prev_instr_category = temp_code_category[i - 1];
         }
 
         code_mask[BLOCKCACHE_INNER_INDEX(instr_address)] = true;
 
-        temp_code[i].instr.raw = n64_read_physical_word(instr_address);
-        temp_code[i].category = instr_category(temp_code[i].instr);
+        temp_code[i].raw = n64_read_physical_word(instr_address);
+        temp_code_category[i] = instr_category(temp_code[i]);
         temp_code_len++;
         instructions_left_in_block--;
 
         bool instr_ends_block;
-        switch (temp_code[i].category) {
+        switch (temp_code_category[i]) {
             // Possible to end block
             case CACHE:
             case STORE:
@@ -133,7 +135,7 @@ void fill_temp_code(u64 virtual_address, u32 physical_address, bool* code_mask)
 #endif
 
     // If we filled up the buffer, make sure the last instruction is not a branch
-    if (temp_code_len == TEMP_CODE_SIZE && is_branch(temp_code[TEMP_CODE_SIZE - 1].category)) {
+    if (temp_code_len == TEMP_CODE_SIZE && is_branch(temp_code_category[TEMP_CODE_SIZE - 1])) {
         logwarn("Filled temp_code buffer, but the last instruction was a branch. Stripping it out.");
         temp_code_len--;
     }
@@ -166,16 +168,16 @@ bool detect_idle_loop(u64 virtual_address) {
         return false;
     }
 
-    if (temp_code_len == 2 && temp_code[1].instr.raw == 0x00000000) {
+    if (temp_code_len == 2 && temp_code[1].raw == 0x00000000) {
         // b -1
         // nop
-        if (temp_code[0].instr.raw == 0x1000FFFF) {
+        if (temp_code[0].raw == 0x1000FFFF) {
             return true;
         }
 
         // j (self)
         // nop
-        if (temp_code[0].instr.op == OPC_J && temp_code[0].instr.j.target == ((virtual_address >> 2) & 0x3FFFFFF)) {
+        if (temp_code[0].op == OPC_J && temp_code[0].j.target == ((virtual_address >> 2) & 0x3FFFFFF)) {
             return true;
         }
     }
@@ -224,7 +226,7 @@ void v2_compile_new_block(
     for (int i = 0; i < temp_code_len; i++) {
         u64 instr_virtual_address = virtual_address + (i << 2);
         u32 instr_physical_address = physical_address + (i << 2);
-        emit_instruction_ir(temp_code[i].instr, i, instr_virtual_address, instr_physical_address);
+        emit_instruction_ir(temp_code[i], i, instr_virtual_address, instr_physical_address);
     }
 
     if (!ir_context.block_end_pc_ir_emitted && temp_code_len > 0) {

diff --git a/src/cpu/dynarec/v2/v2_compiler.h b/src/cpu/dynarec/v2/v2_compiler.h
@@ -7,18 +7,14 @@ INLINE bool is_memory(u64 address) {
     return false; // TODO
 }
 
-typedef struct source_instruction {
-    mips_instruction_t instr;
-    dynarec_instruction_category_t category;
-} source_instruction_t;
-
 // Extra slot for the edge case where the branch delay slot is in the next page
 #define TEMP_CODE_SIZE (BLOCKCACHE_INNER_SIZE + 1)
 #define MAX_BLOCK_LENGTH BLOCKCACHE_INNER_SIZE
 
 extern int temp_code_len;
 extern u64 temp_code_vaddr;
-extern source_instruction_t temp_code[TEMP_CODE_SIZE];
+extern mips_instruction_t temp_code[TEMP_CODE_SIZE];
+extern dynarec_instruction_category_t temp_code_category[TEMP_CODE_SIZE];
 
 bool should_break(u32 address);
 u64 resolve_virtual_address_for_jit(u64 virtual, u64 except_pc, bus_access_t bus_access);

diff --git a/src/cpu/dynarec/v2/v2_compiler_x64.c b/src/cpu/dynarec/v2/v2_compiler_x64.c
@@ -241,7 +241,7 @@ void compile_ir_tlb_lookup(dasm_State** Dst, ir_instruction_t* instr) {
     if (instr->block_length <= 0) {
         logfatal("TLB lookup compiled with a block length of %d", instr->block_length);
     }
-    bool prev_branch = instr->block_length > 1 && (temp_code[instr->block_length - 2].category == BRANCH || temp_code[instr->block_length - 2].category == BRANCH_LIKELY);
+    bool prev_branch = instr->block_length > 1 && (temp_code_category[instr->block_length - 2] == BRANCH || temp_code_category[instr->block_length - 2] == BRANCH_LIKELY);
     static_assert(sizeof(N64CPU.prev_branch) == 1, "prev_branch should be one byte");
 
     ir_set_constant_t prev_branch_const = { .type = VALUE_TYPE_U8, .value_u8 = prev_branch };