Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added de_de #190

Open
wants to merge 2 commits into
base: 1.17-experimental
Choose a base branch
from

Conversation

Pankraz01
Copy link

@Pankraz01 Pankraz01 commented Mar 1, 2021

completely added translation of de_de (German) closes #188

completely added translation of de_de (German)
Copy link
Collaborator

@CreepyCre CreepyCre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes here and there to fit the lore better. Take care to be consistent with naming as well.

Pretty good translation in general though.

src/main/resources/assets/dimdoors/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/dimdoors/lang/de_de.json Outdated Show resolved Hide resolved
"block.dimdoors.wood_dimensional_trapdoor": "Eichen Dimensionsfalltür",
"block.dimdoors.dimensional_portal": "Dimensionsportal",
"block.dimdoors.black_fabric": "Struktur der Realität",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Struktur doesn't really seem to fit the theme. Fabric is more akin to a bunch of entangled thread. (see world thread)
Something like Gewebe/ Geflecht might work better. So in its entirety it might be Realitätsgeflecht.

Might want to check with Codebracker on the symbolizism though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i translate Fabric as Geflecht in general, or just that one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved since you didn't adress the requested changes. I you want to discuss which sounds better you can call me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik

src/main/resources/assets/dimdoors/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/dimdoors/lang/de_de.json Outdated Show resolved Hide resolved
src/main/resources/assets/dimdoors/lang/de_de.json Outdated Show resolved Hide resolved
@Pankraz01 Pankraz01 requested a review from CreepyCre March 1, 2021 14:28
@Waterpicker
Copy link
Collaborator

What's the status on this one?

@Waterpicker
Copy link
Collaborator

Two year poke I guess. Is this stale now?

@Yobrocharlie
Copy link
Contributor

this shit is more stale then a fucking isreal joke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants