Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refetch reference after raising file reference expired exception #62

Closed
wants to merge 1 commit into from

Conversation

Lqlsoftware
Copy link
Contributor

This fix works for handling the FILE_REFERENCE_EXPIRED exception.
The script will try 3 times to refetch the reference which is expired before XD.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #62 (5933bbb) into master (d8fd03d) will decrease coverage by 4.07%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   95.14%   91.07%   -4.08%     
==========================================
  Files           2        2              
  Lines         103      112       +9     
==========================================
+ Hits           98      102       +4     
- Misses          5       10       +5     
Impacted Files Coverage Δ
media_downloader.py 88.63% <61.53%> (-5.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fd03d...5933bbb. Read the comment docs.

@Dineshkarthik
Copy link
Owner

@Lqlsoftware are you working on fixing the code coverage?
If not I can pull in your changes and write required unit-tests and create a new PR which supersedes this one.

@Lqlsoftware
Copy link
Contributor Author

@Dineshkarthik Sorry, I was doing something else today.
The low code coverage is caused by except of 400-request exception, client.get_messages(), log. warning() and log.error() which is not include in current unit-tests.
I have done several tests on those methods and exceptions, which shows that they worked as we excepted.

@Dineshkarthik
Copy link
Owner

@Lqlsoftware I have cherry-picked your changes and added few more changes along with unit-test to increase code-coverage in PR #63
If you are okay with the other PR we can close this and merge the other one.

@Lqlsoftware
Copy link
Contributor Author

Ok! I will close this pr. Great work, man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants