GCA Related Talk

[FrutyX]

This discussion is only for GCA related talk.
Old talk issue - #308.

Please do respect the Code of conduct.

[FrutyX]

@GramThanos one last thing sir and our community standards checklist is complete! I have no control over this.

Enable it: https://docs.github.com/en/communities/moderating-comments-and-conversations/managing-how-contributors-report-abuse-in-your-organizations-repository

Thank ya.

[GramThanos]

Please, don't call me sir... Call me Thanos.

[FrutyX]

Sir Thanos? 😆

[GreatApo]

Conquer of worlds Thanos

[GramThanos]

Snap

[GramThanos]

@FrutyX Do you have access to the actions tab too?

[FrutyX]

Yes, I see it.

[FrutyX]

Hmm, our Greek friends went silent, and you know what? You are doing good!

Gladiatus is currently flooded with bugs and lags, and they are affecting GCA features anyways and it's not in its final stage yet, so better to just wait.

[FrutyX]

What is wrong with this language? Are you like, used to it?

[GreatApo]

Yes... they just don't check if the translation breaks the UI... Some in guild battle report and in most tables. Things are even worse if you disable the addon.

[FrutyX]

.avatar {background-image: url(../resources/avatars/fan_made/4.jpg)!important;}
(no costume)

This is wild as hell, not gonna lie.

EDIT: Upgrade 2.0!
.avatar, .avatar_costume_part, .avatar_costume_animation {background-image: url(../resources/avatars/fan_made/4.jpg)!important;background-position: unset!important}

[FrutyX]

If I was actually more skilled with javascript, I would implement these, because they do look awesome, and with CSS, you can already do wonders.

[GramThanos]

There was a feature that let people pick their own image for their player... it was a pain in the ***.
FYI also the visual corrections on gladiatus visul bug will come back and hunt you one day.

[FrutyX]

FYI also the visual corrections on gladiatus visul bug will come back and hunt you one day.

Oh, I am counting on it, it's all CSS, changing it is nothing hard, things will change, nothing left but to adapt. It is also possible that Gameforge will change something, in that case, I'll just delete it.

Only downside is, that such changes require a new version to be released, which sucks.

[FrutyX]

I have decided.

I was looking at the PROGRESS file again, and with those image previews, it just became too overcomplicated, especially for editing, where you had to use more codes than necessary, so, I have removed all images from PROGRESS.md, to keep things simple.

However, I also created a new file PROGRESS_W_IMG.md, where you have the same progress file, but with images. @SleepingShadow-bit feel free to keep it updated, if you want, but it's not required, you wanted an image version, so I gave it to you.

Trust me, it's simpler this way.
Edit: Yea, I can see the images links are broken, will fix later.

[FrutyX]

Servers with different sides used to work no? I think I've seen somewhere a script that was swapping it, no? It's... uh, completely broken.

The changes I've made are all included in my feature that can be turned off (gladiatus_site_fixes #403) but turning it off is not doing anything, I may have done some small changes outside gladiatus_fixes, but I don't think I could broke it completely (maybe), from a first fast look, I have no idea what's going on.

It could be just one element that broke it, but now to find it...

[FrutyX]

LMAO, I think I've fixed it 04e7bc1, are you proud, daddy Thanos?

[GramThanos]

Nice hack

[FrutyX]

No, not really, it was experimental, only like half of the addon is working. Maybe I should let someone more experienced handle this :-/.

[GramThanos]

Here you go ea960ea

[FrutyX]

Yes, that seems to be simple and working well, I got excited too early, thought it worked, well, multitasking.

Thank ya once more, good fix.

[FrutyX]

Uh, I think I need an explanation, it is a little explained in developer docs, but I need to get in the details, let's say I am making a feature, and I see there: init, preload, load, inject, resolve or there is none of these, so what is the actual difference? I need to know, which one should I use for my specific function, and for all others, that I could possibly make.

It's a bit confusing me.

[FrutyX]

But I don't really need to cross, it's running simply on one specific page. We are talking about one function that is editing a specific part of the page, but it's rendering is visible, but just for a second. And preinject is not an option.

[FrutyX]

I see.

[FrutyX]

But I don't really need to cross, it's running simply on one specific page. We are talking about one function that is editing a specific part of the page, but it's rendering is visible, but just for a second. And preinject is not an option.

I have reviewed the code I was asking about, and basically it should be fine, the javascript elements are using the game's classes and my CSS that is editing a few things is in preinject, so I guess that's it for the improvement, thanks for the advices, Thanos.

[FrutyX]

I never say no to a good advice, if I wanted to simulate the window.load function, I should use inject, right? Just making sure.

[GramThanos]

the inject may be faster than onload. It is actually on DOM load, thus images may not be loaded at the time.

[FrutyX]

It probably does not need a issue, but before I forget it, this little thingie - I keep sometimes swapping folders (branches) and only this one keeps resetting (not touching my settings), perhaps something bad in the settings data?

[GramThanos]

I am not sure what you mean.

[FrutyX]

Is that your favorite sentence? 😄

[GramThanos]

No. My favorite sentence is:
Did you tried turning it OFF and ON again?

[FrutyX]

Well, that's the thing, it does that for me, but it probably shouldn't. But if you are not a developer, that keeps swapping between versions, I guess this isn't really a problem.

[GramThanos]

If you open the browser developer tools and navigate to the application tab, there on the side a section for the website's localstorage. There you can inspect all the settings data saved by the addon. You can investigate if the settings are saved correctly there.

[GramThanos]

@FrutyX fix your indentation in your code editor plz... we use tabs, not spaces.

[FrutyX]

By the way, this is a small thing, but I am aware that you have a donate system via Paypal, you can have a "Sponsor" button above your repository, you just have to choose it in the settings and simply create a new file with a custom link to it.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository

If you wanted, but I think you deserve some support. My permissions are limited, that's why I send you the link.

[GramThanos]

When people donate I feel I have to work on the code :P

[FrutyX]

Perfect. I'm gonna start an advertising campaign :D.

[GramThanos]

@FrutyX When you have time, please check if we are missing something from the changelog.

[SleepingShadow-bit]

When are you releasing the new version? Due to missing translations and adjustment of changelog with photos

[GramThanos]

The version was released. Only google (chrome) is still reviewing the version.
On Firefox and Edge, the version is public.

[FrutyX]

Too late for the train, but we waited long enough, there was time.

You don't have to update the Image PROGRESS file, because it's gonna be purged and prepared for v4.3.7 progress once Thanos updates the version everywhere (and updates the progress everywhere), and translations, well, they will have to go into the next version.

[FrutyX]

You don't have to update the Image PROGRESS file

Plus new features can go straight into the documentation.

[FrutyX]

Only google (chrome) is still reviewing the version.

And finally, Chrome version is now live too.

[FrutyX]

I have a proposition, what if we released a hotfix version instead of an update version? Let's say we keep the current next version 4.3.8-beta but we release a hotfix version 4.3.7-hotfix, the goal is to fix issues without waiting for the next version (which can take another year), in this case, we are talking about the recipes load crash (3a9986c).

You can upload the current master branch and purge the progress, but the next version will stay the same. I mean, hotfixes are a common development thing, but you never done them, I know it's work for Thanos again, but I don't think it's that much work.

[FrutyX]

But we can release a v4.3.8.

Alright, you can fire at will, nothing critical is appearing, and there will be always bugs or things to do, no reason to wait. At least it will satisfy some that want their resources tooltips back...

[FrutyX]

But we can release a v4.3.8.

[GramThanos]

aahahhhaaaa,
fix you should..... the bugs we have....
push we must the version
for I have a lot of work, I can't right now

[FrutyX]

Not like I am an extension expert, but maybe @GramThanos might be interested:
https://blog.mozilla.org/addons/2022/11/17/manifest-v3-signing-available-november-21-on-firefox-nightly/

Most likely, it's easier to have one manifest version rather than two (so V3), but it's possible that Chromium and Mozilla manifest versions will be needed to be little different, depends on the features support and compatibility.

[GramThanos]

I smell more bugs...

[FrutyX]

I don't even know what the point of this post is, probably just for you, to be informational.

Whatever Gameforge is doing with their servers, it's doing no good for GCA features, the features that are loading stuff from the game can get an 503 error, because the server is getting overloaded, mostly we are talking about milliseconds, I even had an idea, that they might set up an request limiter so their server does not crash, who knows.

I have two good examples, one affected feature is the reports list, where there are many drops being loaded and the server simply does not respond, another example is when you cancel a lot of items on the market, it can throw the same error.

I don't know if it possible to create an universal script that would affect all GCA requests to slow them down or retry when they fail, but I am not asking for action, because this isn't on us, it's a server issue. Also, who knows what they'll change in the future, the blank error page got removed too.

[GramThanos]

I think this is not intentional. They must have problems with server with many people. This means that we may have to disable some features that are creating many requests.

[FrutyX]

Sacrificing features? No, not a good solution, this is once again even more work, however I think the features that are creating too many requests in a very short time needs to be altered so they send each request with some time space between them, delayed. Not all at once.

[FrutyX]

Also, without hitting GCA first, think about people using bots and various scripts, they are the ones overloading the server.

It does not happen all the time, so it really depends on the current state of the server, plus GCA triggers these requests only when user action, or on specific pages.

[FrutyX]

@GreatApo 📞 😃 Calling da structural engineer, If I recall correctly, you were the one addressing it, this time I was looking out for it and I know how and why is it happening:

reports.js?4.3.8&built=1664664523646:236 Uncaught TypeError: Cannot read properties of undefined (reading 'getElementsByTagName')
    at Object.change (reports.js?4.3.8&built=1664664523646:236:82)
    at Object.inject (reports.js?4.3.8&built=1664664523646:72:24)
    at fireLoad (reports.js?4.3.8&built=1664664523646:1194:15)

This error is happening when you defeat Dispater (Ντις Πάτερ) and you get the message that you successfully finished UW and got your costume.

[FrutyX]

:D :D

[GramThanos]

[deprecated] please use FrutyX. GramThanos will be remove in the future.

[FrutyX]

[deprecated] please use FrutyX. GramThanos will be remove in the future.

[FrutyX]

Btw, you should know, that I tried looking at this, but I don't know how to approach it, since the URL does not change, CCA thinks the end screen page for UW is still a reports page, and that's why it cannot get the element it wants, because it does not exists.

I tried catching the undefined error and then fix it, but I could not catch it, and it's hard to identify the page since it's still under reports url... it contains a dialog after finishing UW and the Ceres picture, maybe with that you could disable it... I ain't sure.

[GramThanos]

Good job. Then what you have to do is try to find a way to identify if you are on that screen. Maybe ther is a special id or an element on the page, or a special parameter on the url, so the we can check it before running the code.

[FrutyX]

How to get GCA blacklisted in one simple step:

🤣

[FrutyX]

Anyways, what is this? I am now using Notepad++ indent because it's my main editor, but it looks plain stupid on GitHub, for some reason.

Git:

Notepad:

[GramThanos]

You mixed TAB & SPACES indentation. Github used 8 spaces for each tab while your editor used 4. You should clean the code replacing the 4 spaces to 1 tab.

[FrutyX]

Hmm, and which one you use as default? I can see I can change both of them in the settings, I just need the same value as you use, so we all have the same.

[GramThanos]

I think only you are using spaces :P.

[GramThanos]

I prefere tabs. It is easier to use, takes less disk space, and it is length customisable.

[FrutyX]

I am seeing a weird Firefox behavior, it's probably nothing, but I would not like to release some bugged things... This seems to be only happening on Firefox, but I am suspecting that when Thanos compiles the extension it's most likely gonna get fixed and it's caused (I guess) because the extension is only temporal (?).

I have used gca_resources.folder + 'folder/example.jpg' in two of my features, but their image appears to be broken in Firefox, they are not showing, I've checked Edge and Chrome, and it's working normally, the file exists and even the link looks right, but it seems broken...

It also could be a manifest thing, I am not sure... someone else should try loading the beta into Firefox (and test health warning browser notification + the welcome message).

[FrutyX]

I think the URL becomes invalid because it has only temporal ID...

[FrutyX]

Heya,

I wish I would rather bring good news with the new year than bad (if we can call it "bad"), but...

After some time, I have finally decided, to put an end to all my activity in Gladiatus, since it's not really worth the time and no good goal to pursue, this also includes everything related to Gladiatus, which means, that I won't be "helping" with the development anymore.

It was an interesting experience tho, I am no programmer, nobody teached me javascript, I learned all the coding from the internet and well, from GCA codes, so I truly regret nothing. Most likely, I won't be ever using for example javascript in my life again, but like I said, it was indeed interesting.

Now let's be completely honest, there was zero activity here, even tho Apo was the one againts canceling GCA, but I don't blame him, it's true that Gladiatus is a relic at this point, and something like GCA will always need some management and maintenance, which takes time, personal time.

Anyways, this changes nothing, me leaving maybe takes some of the motivation away (if there is any, lol), but you can continue with the development of GCA, but only if you want, you know what it takes, so don't lie to yourselves, the future of GCA is in your hands, it's purely your decision what you want to do with it.

I already deleted my mentions here (readme etc.), but it's possible that I am somewhere else, feel free to delete my name from leftovers. You are also free to remove all my permissions from this repository - and by the way, thank you for trusting me.

And most importantly, I wish you luck in real life, stay safe and have a good health, that is most important than any of this.

Farewell,
some FrutyX.

[GramThanos]

Happy new year @FrutyX. You don't have to delete any mention, either way you left your mark on this project. The progress on the addon has always been like that, don't forget that this is a project we work on more than 10 years...

I wish you the best on your next steps in life. Thank you for being part of GCA!

PS: Never say never... JavaScript is everywhere :)

[GreatApo]

Thank you very much for your contributions Fruty! You left your mark on GCA and I hope you had some nice time doing so!

Going forward, I wish you all then best, good luck and stay healthy... farewell my friend!

[FrutyX]

You know, I am visiting Gladiatus time to time, same with this GitHub, I haven't forgotten.

And I can see it hasn't moved it here much, but I ain't blaming you, it's a matter of time, until GF decides to shut down the servers, because no one except bot users will play Gladiatus nowadays, it is simply a relic of the past.

However, and this is no order, take it as a merely recommendation from me, I think you should do one final version, that will stay, to wrap it up.

Make sure that Manifest V3 thingie works and fix any critical bugs you can find, deploy it out and leave it be, take it as a final strawberry on a cake, and to honor all progress that has been made but wasn't pushed out with the new version.

Anyways, outside Gladiatus stuff, I hope you boys are well, with all that crap going on in the world, you just stay safe and healthy, I really feel that with each year, time passes quicker...

[GramThanos]

@FrutyX your point of view is different than mine. I always worked on the addon during winter or summer vacations. Missing 1 says nothing. :P

[GramThanos]

Anyway, the version was released, and it is under review. I will also work on the website services the next days.

[FrutyX]

Holy crap! I didn't expected you'll go YOLO and just release it (think there are some unfinished things but...), but at least the progress got out and some fixes can be made once is out.

Since I still have permissions (Thanos knew what he was doing), I might take a look at some things personally, because I did quite a few features and changes myself as well, I don't leave my own stuff behind, especially if it should prove problematic.

So, uh, thank you, I guess? Even when I don't play the game anymore, at least my contributions were not for nothing. Now as a last thing, it would be nice to keep it alive, we dont have to create Gladiatus 2.0 tho, hehe.

[FrutyX]

@GreatApo Nice job on the progress, you really got into it.

This is all I asked for, keeping it alive, do some bug-fixing, we really don't want to add new features anyway, since they can only introduce more new bugs, I am with Thanos in this, Gameforge should be the one adding features, it's their game anyway.

By the way, if we ever release another version, you might wanna get rid of this:

I believe it's rather complicated to actually finish it and the need for it... let's just say it does not have that big of importance.

But you do you, of course, I just think we shouldn't leave unfinished things in releases.

[GreatApo]

@GreatApo Nice job on the progress, you really got into it.

This is all I asked for, keeping it alive, do some bug-fixing, we really don't want to add new features anyway, since they can only introduce more new bugs, I am with Thanos in this, Gameforge should be the one adding features, it's their game anyway.

By the way, if we ever release another version, you might wanna get rid of this:

I believe it's rather complicated to actually finish it and the need for it... let's just say it does not have that big of importance.

But you do you, of course, I just think we shouldn't leave unfinished things in releases.

Why? its working :P

[FrutyX]

Current status is satisfactory, once you have the proper time, you may do your own checks (also #476) if everything is working as expected and the current beta version can be released. That is, unless you have any other own plans for fixes/features.

And hopefully, this version will fix most of the main errors, so you can chill again after that, I have no plans myself for now. I wanted it to stay only in keep-alive mode, but kinda got lost in it so there were some unexpected new features added.

[GramThanos]

@FrutyX This is not exactly related to GCA (at least not with the addon part), it has to do with the website's code that is running the arena. @GreatApo is in charge of that. So, I will proceed with a release.

[FrutyX]

What I did not know is, that Apo is in charge of that, very well, proceed.

[GramThanos]

I think I pushed the release correctly.
Pushed to Mozilla, Chrome, and Edge stores and the new version is under review.

[SleepingShadow-bit]

It seems like I have to get active again with the documentation and German translation :D Thx for the update

[GramThanos]

It seems like I have to get active again with the documentation and German translation :D Thx for the update

Don't do it! It is a trap!