Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💬 TALK - Only GCA related #308

Closed
FrutyX opened this issue Dec 26, 2021 · 116 comments
Closed

💬 TALK - Only GCA related #308

FrutyX opened this issue Dec 26, 2021 · 116 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 26, 2021

A talk issue, suitable for GCA development.

Sometimes, you just have a simple question, or you want to suggest something, but it isn't completely up to create a whole new Issue, this is the right place to talk about it.

Rules:

1. As the issue name suggest, only GCA related talk here (applies to links too), Gladiatus topic is still tolerable, nothing else other than that.

2. No vulgarity or spam, keep this Issue clean and when you forget to mention something, just edit your previous post.

3. If you found a bug or want to make a suggestion for a feature or enhancement, create a New issue.

4. If you are having problems with GCA, make sure to read our Troubleshooting guide first.

5. You are free to use emojis and upload images, all in a reasonable amount.

6. Be kind and helpful.

In case of need, more rules might get added. Comments that will not respect these rules will be deleted.

For developer questions, you can also check For developers.

Archive

Archived talk Issues

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 28, 2021

@GramThanos , @GreatApo

There is no point in making a feature request, because I know (98%) that this will never be implement, the reason is simple - too much work, you have your own real life and you are not getting paid enough (heh).

I found the fan made avatars in files, well, a long time ago.

At first, I thought to myself that it's a shame they are not used (as far as I know), so a small fun thing would be, to add them via the addon and you can change your in-game avatar for these, of course you'll be the only one to see that, the opponent will see only Gladiatus default costume. This would be the easiest solution to use them.

Then I got a better idea, but the amount of work for this is insane. Back in the day, where GCA development was most active, this would be maybe possible, but now? I don't know, the motivation and time... I don't blame you.

So the second idea was all about Global Arena, what if we added these custom avatars (costumes) as tier rewards? For completing achievements, like "Win 50 fights to unlock this costume" or "Spend XX/XXX time in top 3 to unlock this costume".

There is still the problem, that you'll be the only one to see them, but, I don't know the capabilities of Global Arena, it could be possible to see the costumes, but only in Global Arena, the implementation is kinda difficult.

A database (MySQL?) would be needed to save the unlocked costumes for each player and then show them in the Global Arena, hard, not impossible (guessing).

In the end, even if they were unlockable as tier rewards, only for you to be visible, it would be still nice, even without the database thing, it's still a lot of work.

I wanted to share with you this, even when I know, that this is not possible.

@GreatApo
Copy link
Member

@GramThanos , @GreatApo

There is no point in making a feature request, because I know (98%) that this will never be implement, the reason is simple - too much work, you have your own real life and you are not getting paid enough (heh).

I found the fan made avatars in files, well, a long time ago.

At first, I thought to myself that it's a shame they are not used (as far as I know), so a small fun thing would be, to add them via the addon and you can change your in-game avatar for these, of course you'll be the only one to see that, the opponent will see only Gladiatus default costume. This would be the easiest solution to use them.

Then I got a better idea, but the amount of work for this is insane. Back in the day, where GCA development was most active, this would be maybe possible, but now? I don't know, the motivation and time... I don't blame you.

So the second idea was all about Global Arena, what if we added these custom avatars (costumes) as tier rewards? For completing achievements, like "Win 50 fights to unlock this costume" or "Spend XX/XXX time in top 3 to unlock this costume".

There is still the problem, that you'll be the only one to see them, but, I don't know the capabilities of Global Arena, it could be possible to see the costumes, but only in Global Arena, the implementation is kinda difficult.

A database (MySQL?) would be needed to save the unlocked costumes for each player and then show them in the Global Arena, hard, not impossible (guessing).

In the end, even if they were unlockable as tier rewards, only for you to be visible, it would be still nice, even without the database thing, it's still a lot of work.

I wanted to share with you this, even when I know, that this is not possible.

Make a feature request 😂
We used to save image urls in player's description but the problem was that that could be exploited, and it takes a lot of work to replace the images in all locations

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 28, 2021

the problem was that that could be exploited

Oh, good then we have a cybersecurity expert, right? I wouldn't mind hearing his opinion too.

And I don't think we need to create another feature request, that will hang here for years, and never be addressed, if you wanted to do this, the info is right here.

@GramThanos
Copy link
Member

Regarding the custom avatars, I liked a lot the initial idea by the old gladiatus tool addon, which allowed you to load different images for both guilds and players. It was really hard applying it everywhere, though the addon structure was not so advance back then. From my point of view the main problem is that it is a very nice way to recover the IP address of other players. This is also one of the reasons why I don't like the idea of auto loading images in messages and parsing links in private messages. In such cases you need a proxy server to hide the client's IP (just like google is doing on your emails or github on external images).

Regarding global arena, at some point if GameForge does not care to implement new features, why should I spend 10 hours coding for them when I can spend 100 and recreate a spin off game? I see more and more people requesting from our addon to develop features that GameForge should develop.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 29, 2021

@GramThanos
An interesting point of view, sadly, it is true.

There is a fine line between "for Gameforge" and "for the addon", it's a matter of perspective, I do see a conflict in this, GCA was made for Gladiatus, but you created the addon, you added all those features, you made it, are you coding for them? Like I've said, there is a conflict I cannot solve.

Gameforge does not listen to their players, so what is the next place they'll go? You know the answer, it's the only option left.

My whole goal was to use these avatars, but unfortunately, I don't see a easy way to use them.

Once we know Gladiatus is gonna truly end, you can prepare your spinoff thingy, I wanna see that :D.

@GreatApo
Copy link
Member

GreatApo commented Dec 29, 2021

The only easy solution to custom avatars is supporting only predefined pictures which are saved in the addon.

@GramThanos
Copy link
Member

You can also allow trusted 3rd party sources (e.g. imgur) or image as a text (e.g. in base64 format). The later will be tricky in validating its sanity.

@SleepingShadow-bit
Copy link
Collaborator

I can't find the feature request for "Custom market prices" and i hope i am right here in the talk thread.
Is it possible to add an "On / Off" switch here?
It is possible that someone would like to have this switched on every now and then without having to rewrite their specific buttons

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 29, 2021

@SleepingShadow-bit
Copy link
Collaborator

Hi there,

following feature "https://github.com/DinoDevs/GladiatusCrazyAddon/blob/master/documentation/features/Documentation%20Market.md#toggle-button-changing-sell-price-always-to-1-gold"
I think the ON / OFF button label is incorrect.
"Activate special sales modes" would be better.

ON = 1G / Auto / Value and the new custom market prices

Ask for clarification or whether I should create a feature request

@SleepingShadow-bit
Copy link
Collaborator

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 1, 2022

@SleepingShadow-bit create a new issue for that with a detailed explanation.

@SleepingShadow-bit
Copy link
Collaborator

Done.

The new version is available on chrome. Thank you guys for your work =)

@SleepingShadow-bit
Copy link
Collaborator

https://github.com/DinoDevs/GladiatusCrazyAddon/blob/master/documentation/features/Documentation%20Global.md#show-forgesmelt-timer-indicator

Do you also have the problem that the link does not lead to the desired post?
Did I do something wrong in the documentary?

@GreatApo
Copy link
Member

GreatApo commented Jan 2, 2022

https://github.com/DinoDevs/GladiatusCrazyAddon/blob/master/documentation/features/Documentation%20Global.md#show-forgesmelt-timer-indicator

Do you also have the problem that the link does not lead to the desired post? Did I do something wrong in the documentary?

The # in a link scrolls the page at the element with the target ID, however, when the images are loading the resulting scroll height is wrong... I would say this is a browser bug/issue.

@SleepingShadow-bit
Copy link
Collaborator

@GreatApo
Should the documentation be adapted to the beta or only stable version?

Otherwise I will create a beta version that will be added afterwards

@GreatApo
Copy link
Member

GreatApo commented Jan 2, 2022

@GreatApo Should the documentation be adapted to the beta or only stable version?

Otherwise I will create a beta version that will be added afterwards

I think the most efficient would be to follow the beta/development version to make it easier and simpler to maintain. Generally we add or improve features so it shouldn't be a huge problem if there are additional stuff in there.
Btw, don't spend time updating the existing images if there are small changes like the quality colors...

@SleepingShadow-bit
Copy link
Collaborator

My edit costs less time than your fabulous programming =)

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 2, 2022

And meanwhile @GramThanos:

"They'll just do everything for me"

sitting-on-couch-al-bundy

🤣 🤣

@GramThanos
Copy link
Member

So many emails... I can't even keep up...

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 3, 2022

Bruh, https://en.gladiatus-tools.com has been down since the new year (I think), now, during the costume event...

I hope he'll revive it, I remember when I was writing an email to Skars to revive his page, and he replied and revived the page :D. I don't know about Michalus tho.

@SleepingShadow-bit
Copy link
Collaborator

SleepingShadow-bit commented Jan 3, 2022

Bruh, https://en.gladiatus-tools.com has been down since the new year (I think), now, during the costume event...

I hope he'll revive it, I remember when I was writing an email to Skars to revive his page, and he replied and revived the page :D. I don't know about Michalus tho.

On Discord from Michalus:
Planned to fix it today, but still in car. Fixing tools will have to wait till tomorrow. Sorry

IMG_20220103_090552

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 3, 2022

Oh, great, thanks for letting me know.

@SleepingShadow-bit
Copy link
Collaborator

Do you play gladiatus with the gca addon on your mobile phone (browser Kiwi https://kiwibrowser.com/ )?

Because, some buttons do not work.
If the add-on is not programmed for the mobile version, please ignore my question

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jan 3, 2022

There are features broken on phones, GCA never mentioned anywhere that it does support phones.

There are too many variables on phones (OS version, browser and it's version etc. etc.). Supporting cross platform would be insanity, it's just my opinion, but you don't want to rewrite half of GCA, just because it doesn't work on phones. Unless you have a team of people experienced with mobile development.

There is a reason, why extensions are not possible to use on Google Chrome mobile and you have to use browsers like Yandex or Kiwi.

@SleepingShadow-bit
Copy link
Collaborator

GCA never mentioned anywhere that it does support phones.

Never said otherwise =) just a question, i am noob about programming =)
And thx for explaining =)

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 19, 2022

Oh, I have noticed that he is an... interesting guy :D.

@GreatApo
Copy link
Member

Oh, I have noticed that he is an... interesting guy :D.

He is just a bit fed up with Gladiatus and we both have more important stuff that we should be doing

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 19, 2022

Ah, that's fine and understandable, actually, sometimes I had a Thanos mood when it comes to Gladiatus, but that's just a mood, there has been done too much work and effort into GCA to just let it burn.

If only Gameforge was thinking the same way, but it's just a company that wants (or needs) money in the end.

@GramThanos
Copy link
Member

I told Apo to shut down the project (and the rest of them) months ago. I expressed my opinion multiple times.

I love the community we set up during the years, but we choose the wrong game and company to do so.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 19, 2022

Well, honestly, I am glad Apo did not listen.

However when it comes to communities and games... they can often change anyway, I think it's because the state of the world - trends, and then some die (some pretty quickly), new ones come, nothing lasts forever.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 19, 2022

And also, when Apo seriously decides to burn it, I will not argue him, we'll lit the candle together.

@GreatApo
Copy link
Member

GreatApo commented Jul 19, 2022

Gameforge is doing what they believe is good for them, and if I was onboard I may have done the same. I am not going to argue on that over a 12y old game. But as Fruty said, we have done too much to just shut it down. Now, if these merges need us to rewrite the whole addon... Fruty pass me the candle hahaha.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 19, 2022

--> 🕯️ <--

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 20, 2022

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

The first round of merges failed... how surprising, right.

Now they will do some core code changes and we can literally get the candle, lol.

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 20, 2022

Obviously I am just trolling Thanos, surely, SURELY nothing will be broken :).

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 20, 2022

lol

And they want to merge servers... if the new ones are not upgraded, it's gonna bloody die.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

I know this was very far from being needed... but I brought to life the GitHub Wiki page.

Take a look Thanos, take a look at the fruits of your work.

@GramThanos
Copy link
Member

I have to rewrite the troubleshooting:P

@SleepingShadow-bit
Copy link
Collaborator

Looks good. Thanks @FrutyX

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

I have to rewrite the troubleshooting:P

pepe

@GramThanos
Copy link
Member

I have to rewrite the troubleshooting:P

pepe

Whaaat? There are some more tricks that you can do to fix problems.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

If it's an enhancement, well, then sure.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

Eh, boys? My nice plans got kinda wrecked.

I wanted to set up GitHub discussions, however when I try to set them up, it gives me an 404 error.

So my guess is, that I don't have the permissions for it, or they are disabled in the repo settings (you need to enable it).

I simply wanted and want to keep Issues issues, and Talk talk, GitHub has many interesting features and options, and since Apo some time ago stated me as the project Administrator, I still feel some responsibility for it, so I am improving it and I want to customize those discussions just simply for GCA.

@GramThanos
Copy link
Member

I enabled them, let me know if you have any problem.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

Thanks Thanos <3

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

let me know if you have any problem.

I think I do, unfortunately, there must be something extra permission settings. I was playing with it in my own repo, and now for example, I can see I cannot even edit the categories, sorry to bother you :D, thought I'm gonna do all myself, unfortunately I am limited.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

Or perhaps I won't be needing them (if there are any), so we can keep it simple and you do it.

Remove categories:

  • Ideas (we keep feature requests in issues)
  • Polls (not needed)
  • Show and tell (not needed)

@GramThanos
Copy link
Member

I promoted you 2 to maintainers. @FrutyX @SleepingShadow-bit
I guess now you have more rights.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

Ah, I now have what I needed, thank you @GramThanos ❤️ .

@SleepingShadow-bit careful 😆.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 23, 2022

It's time to say this issue goodbye, from now on, please continue in #389 (GCA related talk).

#390 for general talk.

Closing.

@FrutyX FrutyX closed this as completed Jul 23, 2022
@FrutyX FrutyX unpinned this issue Jul 23, 2022
@SleepingShadow-bit
Copy link
Collaborator

@SleepingShadow-bit careful 😆.

Oooh shit xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants