Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid or point out feature dependencies #279

Closed
SleepingShadow-bit opened this issue Sep 20, 2021 · 6 comments
Closed

Avoid or point out feature dependencies #279

SleepingShadow-bit opened this issue Sep 20, 2021 · 6 comments

Comments

@SleepingShadow-bit
Copy link
Collaborator

  • The feature "Display Life Potion Use Icon" need to activated "Display extended HP and XP Header Info".
  • The feature "Enable cooldowns sounds notifications (expedition, dungeon, arena)" need to activated "Enable sound system

Can this check another dude?

Solution: Automatic activation of the required feature or no activation allowed with a note?

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 15, 2021

I can offer a different solution, a cheap one, yes, but rather than scripting it, we can just do this, I mean, it's clean and simple.

Výstřižek

Unless Gram wants to script it, connect these two buttons and enable/disable the other button when the main one is changed too.

The other feature is already in works in #278.

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 18, 2021

Okay, this ↑ was probably a crappy idea, this needs to be moved and reworked so it is not dependant:

pot

@GramThanos
Copy link
Member

The best solution would be to somehow show the features as disabled when their dependencies are off.
I don't like asterisks and such notes. Also, features that can be adapted to work without dependencies should work, e.g. the potion icon may could be implemented on the other layout too.

@FrutyX
Copy link
Collaborator

FrutyX commented Dec 19, 2021

The best solution would be to somehow show the features as disabled when their dependencies are off.

That's isn't hard to do in js, in this case, it is, I mean the buttons does not even have an ID, so you can't connect them just like that, there are probably more options, but this is above my skill level.

e.g. the potion icon may could be implemented on the other layout too.

This is honestly the best solution.
Basically both these things I mentioned are already above, but if and how you manage to do it is up to you, I'd rather not stick my nose in it, I tried, it's fire 🔥 .

@GreatApo
Copy link
Member

GreatApo commented Dec 19, 2021

The best solution would be to somehow show the features as disabled when their dependencies are off. I don't like asterisks and such notes. Also, features that can be adapted to work without dependencies should work, e.g. the potion icon may could be implemented on the other layout too.

You are right. Styling can be done easily, for example:

margin-left:20px;
filter: grayscale(100%);

image
but JS probably needs a lot of work.

Lets try to make the features work without dependencies, but I am sure there are settings than need to be linked.

GramThanos added a commit that referenced this issue Dec 24, 2021
@FrutyX
Copy link
Collaborator

FrutyX commented Dec 24, 2021

SLAP, PATCHED.

Nice Gram, nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants