Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClientException should be exported. #260

Closed
abal1000x opened this issue Dec 7, 2023 · 1 comment · Fixed by #262
Closed

HttpClientException should be exported. #260

abal1000x opened this issue Dec 7, 2023 · 1 comment · Fixed by #262
Assignees
Labels
enhancement New feature or request

Comments

@abal1000x
Copy link

Is your feature request related to a problem?

Yes. When i got HttpClientException from teledart, i couldn't catch it, because the exception class are not exported.

Describe the solution you'd like

Refactor the HttpClientException out from src/util/http_client.dart and export it to the teledart.dart

Some code snippet would help?

  Teledart teledart = Teledart(...);

  // This will throws HttpClientException with code 429, because its <10 minutes opened.
  teledart.close();

Additional context

None.

@abal1000x abal1000x added the enhancement New feature or request label Dec 7, 2023
DinoLeung added a commit that referenced this issue Feb 17, 2024
@HeySreelal
Copy link
Contributor

Since #262 is merged, this issue also can be closed now. HttpClientException is also being exported now.

cc: @DinoLeung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants