Fix redirect express delivery address not editable #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersem
reviewed
Aug 11, 2022
There was a problem hiding this comment.
This seems to let the customer edit the address in our checkout, but unfortunately the change is not updated on the order, so the merchant won't know that the customer changed something unless they look in Dintero's backoffice.
When I think more about this functionality, it seems a bit risky: If the customer has first selected a shipping option for the address provided in WooCommerce, that shipping option might not be available for the new address set in the checkout.
|
I think we should hold this until we've had an internal discussion about it. |
|
I agree, the points that you've brought up are valid concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.