Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the onload event #1010

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Fix the onload event #1010

merged 4 commits into from
Jun 30, 2023

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented May 8, 2023 •
edited
Loading

Fixes #1009

There were two issues:

  1. The load event was marked as bubbling which it is not
  2. The load event was deserialized incorrectly

This is a breaking change because it adds a variant to the public event enum. It also marks that enum as non-exhaustive so that it will not be breaking in the future.

@ealmloff ealmloff added bug Something isn't working breaking This is a breaking change labels May 8, 2023
@jkelleyrtp jkelleyrtp merged commit abccc74 into DioxusLabs:master Jun 30, 2023
@jkelleyrtp jkelleyrtp mentioned this pull request Jun 30, 2023
Closed
@ealmloff ealmloff deleted the fix-onload-event branch November 15, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking This is a breaking change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onload event is not triggered as expected
2 participants
@ealmloff @jkelleyrtp