Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo make tidy/miri #1670

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Add cargo make tidy/miri #1670

merged 3 commits into from
Nov 28, 2023

Conversation

Exotik850
Copy link
Contributor

Adds cargo make tidy and cargo +nightly make miri and changes cargo make tests to include tidy

Closes 1472

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo check, fmt, and clippy already exist in the github actions workflow here: https://github.com/DioxusLabs/dioxus/blob/master/.github/workflows/main.yml#L62-L84. Because one of the actions runs cargo make test, this will cause those parts of the CI to always run twice. Can you change the CI to only run the tests part of the tests. I think we should keep the different steps separate in CI because it is useful to see what part is failing in a PR at a glance. We could either duplicate the commands or run different cargo make * in different steps for the CI

@ealmloff ealmloff added tweak Small changes to improve experience ci github ci labels Nov 28, 2023
@Exotik850
Copy link
Contributor Author

Didn't notice the github actions, will fix now!

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It is nice do have an option with everything centralized. Thank you

@ealmloff ealmloff merged commit b4fe382 into DioxusLabs:master Nov 28, 2023
2 checks passed
@Exotik850 Exotik850 deleted the cargo_make_tidy branch November 28, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci github ci tweak Small changes to improve experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a way to run all checks on local machine before contributing
2 participants