Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix false notification/rebuild for dx hot-reload #1684

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

felixf4xu
Copy link
Contributor

try to fix #1566

this PR is more like a workaround, and it might not be perfect. Any comment is welcome.

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added one extra check to make sure the file exists. It appeared to work as is, but it isn't clear from notify's documentation if removing a file will trigger a changed path, so I would rather be safe than run into a panic later

@felixf4xu
Copy link
Contributor Author

if let Ok is better

@ealmloff ealmloff merged commit d404ddf into DioxusLabs:master Dec 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotreload does not work on Windows desktop
2 participants