Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dioxus Playground Hot Reload Support #3098

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

DogeDark
Copy link
Member

This adds hot reload support to the web renderer through the window.postMessage system for dioxus-playground. The devtools-playground feature enables this system.

Required by DioxusLabs/playground#13

@DogeDark DogeDark added enhancement New feature or request web relating to the web renderer for dioxus labels Oct 25, 2024
@jkelleyrtp
Copy link
Member

I think dioxus-devtools should simply expose the hotreload message pipe by default without the additional feature. I do not want to add any more features or [cfg(feature = "xyz")]. Switching over to devtools from hotreload should open the "semantic door" to more changes that turn on bells and whistles that get disabled in release.

Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and small, thanks! :)

packages/web/src/devtools.rs Outdated Show resolved Hide resolved
@jkelleyrtp jkelleyrtp merged commit 273b70e into DioxusLabs:main Jan 7, 2025
29 of 30 checks passed
@DogeDark DogeDark deleted the web-playground-hr branch January 7, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web relating to the web renderer for dioxus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants