Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copy assets progress by moving fetch_add out of trace!(). #3385

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

liigo
Copy link
Contributor

@liigo liigo commented Dec 18, 2024

before this PR:
(note the six (0/6))

  15.509s  INFO Bundling app...
  15.536s  INFO Running wasm-bindgen...
  15.790s  INFO Copying asset (0/6): C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\header.svg
  15.791s  INFO Copying asset (0/6): \\?\C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\main.css
  15.792s  INFO Copying asset (0/6): C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\favicon.ico
  15.794s  INFO Copying asset (0/6): \\?\C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\favicon.ico
  15.795s  INFO Copying asset (0/6): \\?\C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\header.svg
  15.797s  INFO Copying asset (0/6): C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\main.css
  19.87s  INFO Copying app to output directory...

after this PR:

1258.16s  INFO Bundling app...
1258.18s  INFO Running wasm-bindgen...
1260.72s  INFO Copying asset (1/6): C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\favicon.ico
1260.73s  INFO Copying asset (0/6): \\?\C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\favicon.ico
1260.75s  INFO Copying asset (4/6): C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\header.svg
1260.76s  INFO Copying asset (2/6): \\?\C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\main.css
1260.76s  INFO Copying asset (5/6): C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\main.css
1260.77s  INFO Copying asset (3/6): \\?\C:\Users\liigo\tmp\hidx06\Bare-Bones\assets\header.svg
1283. 2s  INFO Copying app to output directory...

@jkelleyrtp jkelleyrtp merged commit cf1940c into DioxusLabs:main Dec 20, 2024
16 of 17 checks passed
@jkelleyrtp
Copy link
Member

Thank you! Good eye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants