Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event closure invoked recursively #3405

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix event closure invoked recursively #3405

merged 1 commit into from
Dec 20, 2024

Conversation

ealmloff
Copy link
Member

We were using the Closure<dyn FnMut> type for the event handling closure. Events can be invoked recursively sometimes which is not allowed with Closure<dyn FnMut>. Switching to Closure<dyn Fn> fixes the issue

Fixes #2882

@ealmloff ealmloff added bug Something isn't working web relating to the web renderer for dioxus labels Dec 19, 2024
@jkelleyrtp jkelleyrtp merged commit ecf8d16 into DioxusLabs:main Dec 20, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working web relating to the web renderer for dioxus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

closure invoked recursively or after being dropped
2 participants
@ealmloff @jkelleyrtp