Assume the virtual dom is not rendering while not diffing components #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
ealmloff
changed the title
jkelleyrtp
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently assume everything except tasks, events, and effects happens while the vdom is rendering. This causes issues with external callbacks in the dom like a scroll handler attached to the window. The rendering flag is used both for warnings and to determine if signals should subscribe to components
This PR fixes those issues by only setting the rendering boolean while rendering and assuming everything else happens when the vdom is not rendering. It also adds a playwright test to check this behavior
Closes #3399