Fix: Asset Cache On Windows & Asset Status #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DogeDark
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to Windows' long-form path variants, cached assets were being deleted causing long rebuilds for apps with lots of assets e.g. docsite.
The asset status would jump around a lot in terms of progress.
Fixes
We use the
duncecrate to canonicalize assets in a few places, replacingfs::canonicalize. The changes work well on Windows, but it would be good to test other platforms. There may be other places we should canonicalize.The asset status now tracks the completed assets instead of the current asset.