Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use main exe name without extension for bundler on windows #3696

Merged
merged 1 commit into from
Feb 8, 2025
Merged

use main exe name without extension for bundler on windows #3696

merged 1 commit into from
Feb 8, 2025

Conversation

oletf
Copy link
Contributor

@oletf oletf commented Feb 5, 2025

fixes msi & nsis bundles having .exe.exe extension in installer created shortcuts as mentioned here.

Haven't tested on other platforms.

@oletf oletf requested a review from a team as a code owner February 5, 2025 14:48
jkelleyrtp
jkelleyrtp approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkelleyrtp jkelleyrtp merged commit f594a65 into DioxusLabs:main Feb 8, 2025
@oletf oletf deleted the fix-bundle-windows branch February 13, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oletf @jkelleyrtp