Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove solved todo note #156

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Remove solved todo note #156

merged 1 commit into from
Jun 12, 2022

Conversation

Weibye
Copy link
Collaborator

@Weibye Weibye commented Jun 12, 2022

Objective

This TODO was fixed in #152, but the note was left unremoved. This cleans that up

@alice-i-cecile alice-i-cecile added the code quality Make the code cleaner or prettier. label Jun 12, 2022
@alice-i-cecile alice-i-cecile merged commit a2eff07 into DioxusLabs:main Jun 12, 2022
@Weibye Weibye deleted the fix-todo-note branch June 12, 2022 07:54
jkelleyrtp pushed a commit that referenced this pull request Oct 10, 2022
@Weibye
Fix Todo note (#156)
db25d95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality Make the code cleaner or prettier.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weibye @alice-i-cecile