Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment typos #164

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix comment typos #164

merged 1 commit into from
Jun 14, 2022

Conversation

mcrvaz
Copy link
Contributor

@mcrvaz mcrvaz commented Jun 14, 2022

Objective

I'm trying to start contributing to this project and fixing comment typos seemed like a good way to do so :)

Context

Discuss any context that may be needed for reviewers to understand the changes you've made.
This may include related issues, previous discussion, or links to documentation or code.

Feedback wanted

I'm not sure if this is common, but maybe it would be cool to have some spell checking in the CI pipeline. Specially since all of the typos were caught by a VSCode extension, so it should be easy to automate.

VSCode also removed some whitespaces when saving. I don't think this will cause any issues, but let me know!

@alice-i-cecile
Copy link
Collaborator

Thanks! This is a great place to start. If you're interested in adding spell-checking to the CI; please feel free to open a PR :)

On some projects it's too noisy due to invented words, but I think it should be fine here as long as we can add an allowlist.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) June 14, 2022 00:15
@alice-i-cecile alice-i-cecile merged commit ed3749c into DioxusLabs:main Jun 14, 2022
jkelleyrtp pushed a commit that referenced this pull request Oct 10, 2022
Co-authored-by: Marcello Vaz <marcello@pixodust.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants