Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup new_with_children() uses #194

Merged
merged 3 commits into from
Jun 26, 2022
Merged

Cleanup new_with_children() uses #194

merged 3 commits into from
Jun 26, 2022

Conversation

Weibye
Copy link
Collaborator

@Weibye Weibye commented Jun 26, 2022 •
edited
Loading

Objective

Fixes #189

Context & Feedback

I haven't made any changes to the generated code nor it's generation-script, so it will keep producing leaf-nodes using new_with_children() but I reckon that is acceptable.

@alice-i-cecile alice-i-cecile added the code quality Make the code cleaner or prettier. label Jun 26, 2022
alice-i-cecile
alice-i-cecile approved these changes Jun 26, 2022
View reviewed changes
Copy link
Collaborator

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dramatically nicer!

And yeah, we can leave the generation script for now.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) June 26, 2022 20:05
@alice-i-cecile alice-i-cecile merged commit 83a815b into DioxusLabs:main Jun 26, 2022
jkelleyrtp pushed a commit that referenced this pull request Oct 10, 2022
@Weibye @alice-i-cecile
Cleanup new_with_children() uses (#194)
832e2da 
* Cleanup `new_with_children()` uses

* Format

* Update scripts/gentest/src/main.rs

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
code quality Make the code cleaner or prettier.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace old uses of new_with_children with new_leaf
2 participants
@Weibye @alice-i-cecile