-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Overflow::Scroll
#446
Support Overflow::Scroll
#446
Conversation
I agree: that's an unhelpful spec setup.
I think we should probably be consistent rather than clever here. I can't imagine this making a performance difference, and fractional sizes are reasonable.
That seems sensible: uneven scroll bars definitely seem wrong. |
2fbd91c
to
b56f22f
Compare
b56f22f
to
bffafc7
Compare
bffafc7
to
95407ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good docs, clean code. Great tests as always.
Objective
overflow: scroll
for those wanting to faithfully render web layouts.Tasks
Context
overflow
property #304.Overflow::Hidden
#424Feedback wanted
scrollbar_width
deviates from the spec. The spec only allowauto
,thin
ornone
and the user agent must decide what actual widths these correspond to. Whereas I've allowed a pixel value to be specified. I think this difference is justified because Taffy is aimed at "user agents" rather than end users.I've madescrollbar_width
au8
to save on space. Does this seem reasonable, or do you think I should make it anf32
like everything else?scrollbar_width
has been converted tof32
in response to feedback.scrollbar_width
for both axis (the overflow property still applies separately in each axis). So IF there is a scrollbar in both axis then they must both be the same size, does this seem reasonable.