Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc isActive problem #181

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Fix doc isActive problem #181

merged 3 commits into from
Jul 14, 2020

Conversation

LyonJack
Copy link
Contributor

change override void OnPreviewGotKeyboardFocus to OnPreviewMouseLeftButtonUp

@LyonJack
Copy link
Contributor Author

RP #71

@Dirkster99
Copy link
Owner

Hi @LyonJack can you please use TAB character based indentations? It is otherwise very hard to see the changes because the whole document is marked as changed in GitHub's Web-Interface. Thank you Drk

@LyonJack
Copy link
Contributor Author

Where is the setting of tab character indentations?I use the default setting of vs,when I try to 'Ctrl + K +D' to format the codes,all of the codes‘ indentations will be changed

@LyonJack
Copy link
Contributor Author

LyonJack commented Jul 13, 2020

It’s the chang of all my commit:
1、change override void OnPreviewGotKeyboardFocus to OnPreviewMouseLeftButtonUp
2、change the debug info
3、fix #71 ,look the picture of the chang
87227203-fbe3a900-c3cb-11ea-8fb6-e7f2b52ed757

@Dirkster99
Copy link
Owner

OK, I understand the change now but the indentation in the file in your branch is not based on the TAB character as you can see in this image where I compare the file in:

  • your branch (on the left) with the file in
  • dirkster99/AvalonDock/master branch

I have used Edi to visualize SPACE versus TAB character but you can use any editor (VS, Notepad++) to make Spaces and TABS visible
Untitled

The VS Community Setting I am using is this (but there might be a way to make this project specific):
Untitled1

I normally don't care that much about it and change it later to TABS but it makes the [merge view]
(master...LyonJack:master) increasingly hard to interprete because it simple shows the whole file as being changed :-(

Untitled3

@Dirkster99 Dirkster99 merged commit dc16d20 into Dirkster99:master Jul 14, 2020
@LyonJack
Copy link
Contributor Author

next time I'll use tab

@Dirkster99
Copy link
Owner

OK no big deal - I just thought I mention it because its a bit of a hutzle - I used to use spaces as well but somehow everyone else seems to prefer TABS so I switched to TABS some time ago ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants