Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reopening of Floating windows after they were closed from Unload … #51

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

scdmitryvodich
Copy link
Contributor

…handler of DockingManager

In PR #36 I did not take into account that InternalClose of LayoutFloatingWindowControl sets _internalCloseFlag flag to true. It's become cause of issue when floating window not reopens after we unload and load the main window (and docking manager as well).
This bug can be represented in MLibTest project by next steps:

  1. Add TabControl to MainWindow.xaml, by next template:
<TabControl Grid.Row="1">
    <TabItem Name="tab1" Header="tab 1">
        <avalonDock:DockingManager x:Name="dockManager"
            ...
        </avalonDock:DockingManager>
    </TabItem>
    <TabItem Name="tab2" Header="tab 2">
        <TextBlock Text="tab2"></TextBlock>
    </TabItem>
</TabControl>
  1. Start application and undock any panel;
  2. Switch to the tab 2
  3. Switch back to the tab 1
    As result the floating window with undocked panel will not appear

@Dirkster99 Dirkster99 merged commit 1615119 into Dirkster99:master Jul 17, 2019
@Dirkster99
Copy link
Owner

Hi Dimitry,
thanks for the detailled test explaination - I can verify your results and have used your test workflow to create another test case in order to ensure this is not broken in future releases :-)

https://github.com/Dirkster99/AvalonDock/wiki/Loading-and-Unloading-DockingManager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants