Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better experience draging documents arround #72

Merged
merged 4 commits into from
Sep 26, 2019

Conversation

jogibear9988
Copy link
Contributor

No description provided.

Copy link
Owner

@Dirkster99 Dirkster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the editorconfig file? Is this needed for anything in particular?

@jogibear9988
Copy link
Contributor Author

yes. my system uses crlf as lineendings. But in avalondock it is only linefeed. With this, visual studio does not change it, see https://editorconfig.org

@jogibear9988
Copy link
Contributor Author

@Dirkster99 what do you think about the patch?

@Dirkster99
Copy link
Owner

Dirkster99 commented Sep 7, 2019

Sorry, I was a little bit busy with other things this week. I tested your patch with the:

  • TestApp application and
  • MLibTest

MLibTest

  1. Tool Windows can be dragged (seems to be OK),
  2. Documents (use File>New or File>Open to open a txt file) cannot be dragged off from the document pane (?)

TestApp

  1. A tool window that I drag off from the MainWindow appears in a completely different spot on the screen (maybe because I use a 4K screen?)
  2. Documents cannot be dragged off the document pane (same as in MLibTest)

Did you get these things to work on your system or did you test in a different way/test app?

@Dirkster99
Copy link
Owner

...would you be OK if I commit the editorconfig file into the master? I think this is really helpful ...

@jogibear9988
Copy link
Contributor Author

Yes.

@jogibear9988
Copy link
Contributor Author

I've the problem, without this commit the draging of documents most of the time does not work.

And I don't think that the ToolWindow Position has anything to do with this commit. It changes only the Code of LayoutDocumentTabItem.cs

@Dirkster99
Copy link
Owner

Dirkster99 commented Sep 9, 2019

I added the .editorconfig file to master.
cc697aa

My experience when dragging a document is that it is initially invisible (I have to release the left mouse button to actually see the floating document window) but the docking buttons do appear when I move the mouse over the docking button position (even without releasing the mouse button).

So, the current document drag&drop experince is not the best for me but it works and lets me re-arrange documents when I need it.

I cannot re-arrange any document via drag&drop when I test you branch (the document is fixed in its position). Maybe, our computers have completely different timings - I am not sure about this one - but I am sure its not an improvement for me :-(

From my point of view , the only things missing are:

  • the floating document window never shows unless I release the mouse button after starting the drag operation and

  • the Overlay Window does not show unless I position the mouse over a button position or I rease the mouse button to drag the floating window

What I find strange is that the tool window drag&drop experience is as expected - so, maybe we should just try to work out where these work different (using log4net or some other logging) and find a better fix for this?

@Dirkster99
Copy link
Owner

I am closing this as it seems to get older and needs more work - sorry

@Dirkster99 Dirkster99 closed this Sep 23, 2019
@jogibear9988
Copy link
Contributor Author

@Dirkster99 I've reworked so the ordering also works, maybe you can try once more

@Dirkster99
Copy link
Owner

sure, no problem, I'll give it a retry...

@Dirkster99 Dirkster99 reopened this Sep 23, 2019
@Dirkster99
Copy link
Owner

Dirkster99 commented Sep 23, 2019

I just noticed that we can now build the multitargeting .netcore and .net on AppVeyor using VS 2019 Preview only

The extra choco line does not seem to be required any longer:

install:
  - cmd: choco install dotnetcore-sdk --pre

...just mentioning it because I got an error with the choco line probably because the system now becomes confused with 2 .netcore SDK's being present on the build system ...(?) ...so, if you get an error on AppVeyor about this it might be useful to remove the package and see if thats fixing it :-)

@jogibear9988
Copy link
Contributor Author

seems also Preview here could be removed:

image: Visual Studio 2019 Preview

see

  https://github.com/icsharpcode/AvalonEdit/blob/master/appveyor.yml

and also the global json sdk name...

@jogibear9988
Copy link
Contributor Author

@Dirkster99 does it work better?

@Dirkster99 Dirkster99 merged commit abf4df3 into Dirkster99:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants