-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better experience draging documents arround #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the editorconfig file? Is this needed for anything in particular?
yes. my system uses crlf as lineendings. But in avalondock it is only linefeed. With this, visual studio does not change it, see https://editorconfig.org |
@Dirkster99 what do you think about the patch? |
Sorry, I was a little bit busy with other things this week. I tested your patch with the:
MLibTest
TestApp
Did you get these things to work on your system or did you test in a different way/test app? |
...would you be OK if I commit the editorconfig file into the master? I think this is really helpful ... |
Yes. |
I've the problem, without this commit the draging of documents most of the time does not work. And I don't think that the ToolWindow Position has anything to do with this commit. It changes only the Code of LayoutDocumentTabItem.cs |
I added the .editorconfig file to master. My experience when dragging a document is that it is initially invisible (I have to release the left mouse button to actually see the floating document window) but the docking buttons do appear when I move the mouse over the docking button position (even without releasing the mouse button). So, the current document drag&drop experince is not the best for me but it works and lets me re-arrange documents when I need it. I cannot re-arrange any document via drag&drop when I test you branch (the document is fixed in its position). Maybe, our computers have completely different timings - I am not sure about this one - but I am sure its not an improvement for me :-( From my point of view , the only things missing are:
What I find strange is that the tool window drag&drop experience is as expected - so, maybe we should just try to work out where these work different (using log4net or some other logging) and find a better fix for this? |
I am closing this as it seems to get older and needs more work - sorry |
@Dirkster99 I've reworked so the ordering also works, maybe you can try once more |
sure, no problem, I'll give it a retry... |
I just noticed that we can now build the multitargeting .netcore and .net on AppVeyor using VS 2019 Preview only The extra choco line does not seem to be required any longer:
...just mentioning it because I got an error with the choco line probably because the system now becomes confused with 2 .netcore SDK's being present on the build system ...(?) ...so, if you get an error on AppVeyor about this it might be useful to remove the package and see if thats fixing it :-) |
seems also Preview here could be removed: Line 8 in b9da31c
see
and also the global json sdk name... |
@Dirkster99 does it work better? |
No description provided.