Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support disable editingTip Fixes #37 #43

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

heartacker
Copy link
Contributor

fixed #37 and fixed build error

@Dirkster99
Copy link
Owner

I am not sure how this fix is supposed to work. When I add the IsEnableValidatingIndicator="False" property to any demo view in the UpDownDemoLib project I am getting the error message below. I suggest we use a default value of False since I have the impression that most users do not want this feature by default (most people know how to type a valid number in a certain place).

image

@heartacker heartacker force-pushed the heartacker/issue37+ branch from caf1d7d to 55cbf1d Compare July 20, 2022 00:14
@heartacker
Copy link
Contributor Author

  1. now it works
  2. make it false by default

@heartacker heartacker force-pushed the heartacker/issue37+ branch from 8865677 to 96895fe Compare July 20, 2022 02:24
@Dirkster99 Dirkster99 merged commit d909c4a into Dirkster99:master Jul 20, 2022
@heartacker heartacker deleted the heartacker/issue37+ branch August 5, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditingVisibility and EditingColorBrush customizable
2 participants