Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tons of improvements #288

Closed
wants to merge 21 commits into from
Closed

Tons of improvements #288

wants to merge 21 commits into from

Conversation

cloudskies
Copy link

Single PR to update and make everything better:

Updates actions,
Updates snippet classes,
Updates build script,
Updates manifest,
And better read me.

cloudskies and others added 6 commits May 23, 2024 19:30
Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 5.9.2 to 6.6.2.
- [Release notes](https://github.com/mongodb/node-mongodb-native/releases)
- [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md)
- [Commits](mongodb/node-mongodb-native@v5.9.2...v6.6.2)

---
updated-dependencies:
- dependency-name: mongodb
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@p0rtL6
Copy link
Member

p0rtL6 commented May 24, 2024

After reviewing this request, I have decided to deny it for a couple reasons:

  • A decent chunk of these changes are small formatting changes that are either stylistic, or do not impact functionality.
  • Some of these changes seem unnecessary, I do not really see the need for Dependabot, or the changes to the actions/build.
  • Due to some recent infrastructure changes, this repository will be undergoing a heavy rework in the near future. (removal of actions and build scripts entirely, removal of json database, etc.)
  • After these changes, this repository will essentially be entirely "cosmetic," it will play no role in the actual functionality of USRBG.

I do however, appreciate the effort made to contribute to this project, and if you would like to revisit this project after the major changes happening soon, I encourage you to do so. If you have any questions, or any changes you still think should be merged, feel free to comment on here or reach out to me on discord (p0rtl6).

@p0rtL6 p0rtL6 closed this May 24, 2024
@cloudskies
Copy link
Author

I think you can still merge this till usrbg gets reworked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants