Updated documentation #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some information regarding this script running/not running depending on the job status.
…tation Update README.md
iamtraction
requested changes
Jul 31, 2020
| @@ -50,6 +50,8 @@ looking. You've came to the right place. | |||
| this repository to show your love. | |||
|
|
|||
| ### Note | |||
| - If within your gitlab CI Code, you have a pause within the script code, this notiction yml code will still run, to fix this, we need to add allow_failure: false, this will mean the job will not run unless told to(see screenshot) | |||
There was a problem hiding this comment.
Suggested change
| - If within your gitlab CI Code, you have a pause within the script code, this notiction yml code will still run, to fix this, we need to add allow_failure: false, this will mean the job will not run unless told to(see screenshot) | |
| - If you pause the GitLab CI build, `after_success` still gets triggered resulting in this webhook notification being fired. To work around this, we need to add `allow_failure: false` to the config (see screenshot). |
Rephrased the sentence.
There was a problem hiding this comment.
(see screenshot)
Did you forget to add the screenshot?
There was a problem hiding this comment.
Screenshot not needed, as it will be different per CI setup.
There was a problem hiding this comment.
Then why is (see screenshot) added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.