add: popover menu for setting button sheet, close #43 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dreamy-dijkstra-527e49 pending review.Visit the deploys page to approve it
|
|
Hi @howard-tzw, thank you for the contribution! The new menu looks great! However, I still want to keep the old bottom sheet on mobile screen size. Could the new menu only show on the desktop screen? You can use Vuetify breakpoint API: Desktop Design: https://www.figma.com/file/nTYqE10obqYSy2x9zY6Oer/Disfactory_UI_design?node-id=494%3A7845 |
howard-tzw
force-pushed
the
patch-issue-43
branch
2 times, most recently
from
786fbab to
8002f4c
Compare
howard-tzw
force-pushed
the
patch-issue-43
branch
from
8002f4c to
ceb6f48
Compare
|
Hi @Yukaii, I updated the commit for the old button on mobile screen size, please help me review the code, thanks! |
Closed
|
It works pretty well! Thank you for the contribution @howard-tzw 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue #43