Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(docs): update towncrier to v22.8.0 #763

Merged
merged 4 commits into from
Sep 30, 2022
Merged

deps(docs): update towncrier to v22.8.0 #763

merged 4 commits into from
Sep 30, 2022

Conversation

onerandomusername
Copy link
Member

Checklist

  • If code changes were made, then they have been tested
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: documentation Improvements or additions to documentation/examples t: dependencies Addition/update/removal of dependencies skip news labels Sep 24, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Sep 24, 2022
@onerandomusername onerandomusername changed the title deps(docs): update towncrier to the latest version deps(docs): update towncrier to v22.8.0 Sep 26, 2022
shiftinv
shiftinv reviewed Sep 30, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@shiftinv
Copy link
Member

I can't find a changelog for sphinxcontrib-towncrier, but looking at the diff compared to 0.2.1a0, conf.py should use sphinxcontrib.towncrier.ext:
sphinx-contrib/sphinxcontrib-towncrier@37cdf28

sphinxcontrib.towncrier still works since it's backwards compatible, but it would be better to follow the docs.

shiftinv
shiftinv approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shiftinv shiftinv merged commit 4ea452e into master Sep 30, 2022
@shiftinv shiftinv deleted the deps/towncrier-update-22 branch September 30, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
skip news t: dependencies Addition/update/removal of dependencies t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@onerandomusername @shiftinv