Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddUnimportedPackages: true overwrites file header on autoimport #904

Closed
logrusorgru opened this issue Jan 9, 2019 · 1 comment · Fixed by KurokuLabs/margo#100
Closed

AddUnimportedPackages: true overwrites file header on autoimport #904

logrusorgru opened this issue Jan 9, 2019 · 1 comment · Fixed by KurokuLabs/margo#100

Comments

@logrusorgru
Copy link
Contributor

logrusorgru commented Jan 9, 2019 •
edited
Loading

Automatic import overwrites file head.

// Configure general auto-completion behaviour
&golang.MarGocodeCtl{
	// ...
	AddUnimportedPackages: true,
	// ...
},

gosublime_autoimport_overwriting_x4
@logrusorgru logrusorgru mentioned this issue Jan 12, 2019
Closed
DisposaBoy added a commit that referenced this issue Jan 12, 2019
@DisposaBoy
Fix #904
66dc145
@DisposaBoy
Copy link
Owner

There's still at least one more edge-case left, but the main issue should be fixed now.

DisposaBoy added a commit to DisposaBoy/margo that referenced this issue Jan 19, 2019
@DisposaBoy
Use a code-generation strategy instead of modifying the AST when addi…
70ef5f1 
…ng imports.

The latter is a too unreliable when there are comments involved.
This should fix DisposaBoy/GoSublime#904 completely.
@DisposaBoy DisposaBoy mentioned this issue Jan 19, 2019
Merged
DisposaBoy added a commit to KurokuLabs/margo that referenced this issue Jan 19, 2019
@DisposaBoy
Use a code-generation strategy instead of modifying the AST when addi…
47ac6a0 
…ng imports. (#100)

The latter is a too unreliable when there are comments involved.
This should fix DisposaBoy/GoSublime#904 completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a code-generation strategy to add imports DisposaBoy/margo
2 participants
@DisposaBoy @logrusorgru