Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add %w to syntax for Errorf wrapping verb. #951

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Add %w to syntax for Errorf wrapping verb. #951

merged 1 commit into from
Nov 23, 2019

Conversation

logrusorgru
Copy link
Contributor

Since, fmt.Errorf has %w verb, we should properly highlight it.

Also, for go1.13 go vet doesn't recognize Errorf and allows the %w for Sprintf and similar methods. For more information see golang/go#32070 (comment)

@DisposaBoy DisposaBoy merged commit 5134a14 into DisposaBoy:development Nov 23, 2019
@DisposaBoy DisposaBoy mentioned this pull request Nov 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logrusorgru @DisposaBoy