Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XMLHttpRequest API and browser-style EventTarget #168

Merged
merged 22 commits into from
Sep 29, 2023
Merged

Add XMLHttpRequest API and browser-style EventTarget #168

merged 22 commits into from
Sep 29, 2023

Conversation

Xmader
Copy link
Member

@Xmader Xmader commented Aug 22, 2023 •
edited
Loading

Aims to be spec-compliant.

Missing parts from the spec (not covered in this PR):

@Xmader Xmader changed the base branch from main to Xmader/feat/url August 25, 2023 08:22
@Xmader Xmader marked this pull request as ready for review August 25, 2023 11:34
@Xmader
Copy link
Member Author

Xmader commented Aug 25, 2023 •
edited
Loading

TODO:

  • Keep the event-loop running when sending requests
  • Fix error handling, onerror
  • onabort
  • ontimeout
  • Write tests, how? make requests to a local server?
  • default headers
  • xhr.upload progress: processRequestEndOfBody and processRequestEndOfBody
  • Python 3.12 support: issue in aiohttp

Hamada-Distributed
Hamada-Distributed reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@Hamada-Distributed Hamada-Distributed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, no big changes, just a few comments, will approve when you answer them.

python/pythonmonkey/builtin_modules/XMLHttpRequest-internal.py Show resolved Hide resolved
python/pythonmonkey/builtin_modules/XMLHttpRequest-internal.py Show resolved Hide resolved
python/pythonmonkey/builtin_modules/XMLHttpRequest.js Show resolved Hide resolved
@Xmader Xmader changed the title add XMLHttpRequest API Add XMLHttpRequest API and browser-style EventTarget Sep 1, 2023
@zollqir zollqir merged commit 24ed010 into Xmader/feat/url Sep 29, 2023
4 of 5 checks passed
@Xmader Xmader deleted the Xmader/feat/XMLHttpRequest branch March 5, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zollqir zollqir zollqir approved these changes

@wesgarland wesgarland Awaiting requested review from wesgarland

@Hamada-Distributed Hamada-Distributed Awaiting requested review from Hamada-Distributed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xmader @zollqir @Hamada-Distributed