Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include examples from Apollo Federation docs #100

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

benjaminkimball
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kzlsakal kzlsakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates to the README, thank you for the PR! Left a few comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@benjaminkimball benjaminkimball changed the title Update README to include examples from Apollo Federation docs WIP: Update README to include examples from Apollo Federation docs Jul 8, 2024
@benjaminkimball benjaminkimball marked this pull request as draft July 8, 2024 22:54
@benjaminkimball benjaminkimball changed the title WIP: Update README to include examples from Apollo Federation docs Update README to include examples from Apollo Federation docs Jul 8, 2024
@benjaminkimball
Copy link
Contributor Author

Oops, should have marked this as a draft! Thanks for the feedback, @kzlsakal. I'll address them as I finish up my clarifications and additions.

@benjaminkimball benjaminkimball marked this pull request as ready for review July 31, 2024 16:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kzlsakal kzlsakal added the documentation Improvements or additions to documentation label Jul 31, 2024
Co-authored-by: Doruk Gurleyen <dorukgurleyen@gmail.com>
@kzlsakal kzlsakal merged commit 2ae5951 into DivvyPayHQ:main Jul 31, 2024
3 checks passed
@benjaminkimball benjaminkimball deleted the readme-refresh branch July 31, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants