Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the version number and link for most updated version of Python for macOS #1598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lwyso
Copy link
Contributor

@lwyso lwyso commented Oct 17, 2019

No description provided.

Copy link
Contributor Author

@lwyso lwyso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 3.7 ( not 3.8 as 3.8 is only for 64 bits)

@das-g das-g changed the title changed the version number and link for most updated version of Pytho… changed the version number and link for most updated version of Python for macOS Oct 17, 2019
Copy link
Contributor

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will also need to update the PythonAnywhere setup (https://tutorial.djangogirls.org/en/deploy/#configuring-our-site-on-pythonanywhere) to refer to the right version. I tried using Python 3.7 and 3.8 in PythonAnywhere and couldn’t get it working, so this might need to wait for PA to support either versions.

@das-g
Copy link
Member

das-g commented Oct 19, 2019

As long as the code doesn't use features from the newer Python versions, it should be compatible to older ones. So using Python 3.7 or 3.8 locally on macOS while still using Python 3.6 on PythonAnywhere should work fine, as long as we only use Python 3.6-compatible source code, which we have to anyway, as long as participants on some other operating systems will use Python 3.6 locally for the tutorial.

@thibaudcolas
Copy link
Contributor

thibaudcolas commented Oct 19, 2019

@das-g I think it will be confusing to participants that they are using different versions in different places, and it doesn’t seem that far-fetched to me that the tutorial might be updated to use newer Python features without realising that PythonAnywhere is still on 3.6.

It probably doesn’t matter much but it’s not like Python 3.6 is going away anytime soon so it also doesn’t hurt to stay on it until the whole tutorial can be switched over to a newer version.

@thibaudcolas
Copy link
Contributor

For reference here is the Python 3.5 to 3.6 PR: #1086.

@das-g
Copy link
Member

das-g commented Oct 19, 2019

@das-g I think it will be confusing to participants that they are using different versions in different places,

That might indeed be an issue. Note though, that the Windows instructions already tell the participants to install the latest stable version of Python, without referring to a specific version number, while the Linux instructions tell you that Python 3.6 or any version above will be fine (which should in fact be the case).

and it doesn’t seem that far-fetched to me that the tutorial might be updated to use newer Python features without realising that PythonAnywhere is still on 3.6.

I don't think there's much danger of that happening, as those making those changes would hopefully also test them on PythonAnywhere and as those reviewing them would hopefully test them on other Python versions. What could happen is that when trying some stuff for themselves during or after the tutorial, participants might start to use features that work on their local python version but not on the one on Python anywhere. But that too seems unlikely to happen to total novices who wouldn't be able to understand that situation and for more advanced learners it can be a valuable learning experience of its own.

@das-g
Copy link
Member

das-g commented Oct 19, 2019

It probably doesn’t matter much but it’s not like Python 3.6 is going away anytime soon so it also doesn’t hurt to stay on it until the whole tutorial can be switched over to a newer version.

Agreed.

@lwyso Are you OK if we close this pull request without merging it for now? There's probably not much value in keeping it open until PythonAnywhere supports a newer Python version.

Or do we want to make the macOS instructions similar to the Windows and Linux ones, telling that 3.6 and above can be used, and for installation just ask the participants to install the latest stable without referring to a specific version number?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants