-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to html5 and bootstrap4 #1681
Migration to html5 and bootstrap4 #1681
Conversation
@ekohl I have tested all commits above by doing the updated tutorial from the stagging site https://django.nikz.in/en There is some additional code I have added to the Django site shown above. The base.html file has a vacant space on the right side when using
Since this code is not inside the above commit, I would like your suggestion on it. Should I add it and push it into this PR? Following is the current structure of the blog app: |
I don't think we should encourage ads. It's fine to keep it small and empty if it means we don't overwhelm students. Perhaps you can add a side bar in the extension tutorial. |
This comment has been minimized.
This comment has been minimized.
I like @ekohl's idea of making that a tutorial extension. The more often we let participants cut and paste and the longer the cut-and-pasted code blocks are, the less likely it is that participants will look at these code carefully, try to understand them and maybe ask their coaches about what those code blocks' purpose is and how the code works. The goal of the Django Girls tutorial is to make programming and software development approachable and to make it seem less like obscure magic. So it shouldn't be like a lengthy and opaque incantation, that has been passed down to you by higher powers and that you have to exactly reproduce to mystically attain its intended effect. Instead, it should provide participants with a glimpse of how software development works (including aspects other than programming, like revision control and deployment) and provide them with a chance of understanding what they're told to do, so that they can become creative themselves. Therefore, the Django and web development part of the Django Girls tutorial proper should stick to only making a "minimal viable product" for the blog software, and to getting that deployed. (Actually, what the tutorial has the participants currently build, is not even "minimal viable" but just "minimal" in even aspects that are more central than a polished layout with perfectly used screen estate, such as security. E.g., for the sake of brevity, the site's secret key is simply left card-coded and pushed into a public GitHub repo.) |
@das-g That is a valid point. I'll follow that concept with the content. @ekohl In that light, I modified "col-md-8" to just "col". It will expand the content to 100% width inside container. Otherwise we can make it "col-md-12". Either way, that vacant space has to go. It troubled my focus when I started django girls tutorial at my learning stage.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Much less overwhelming now, I think.
IMO only minor issues left:
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Co-authored-by: Raphael Das Gupta <github.com@raphael.dasgupta.ch>
Co-authored-by: Raphael Das Gupta <github.com@raphael.dasgupta.ch>
Co-authored-by: Raphael Das Gupta <github.com@raphael.dasgupta.ch>
@das-g Is there anything more needed in this PR to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything more needed in this PR to merge?
I must confess I lost track, but I think it's fine now. What do you say @ekohl?
I guess this PR might be falling in to lost and found. |
Eh, I'll merge this as-is. |
if no other article elements have been mentioned, yet. (Previously they were `div` elements and the now-`header` element preceding them was then also a `div`. But sind DjangoGirls#1681 not anymore.)
if no other article elements have been mentioned, yet. (Previously they were `div` elements and the now-`header` element preceding them was then also a `div`. But since DjangoGirls#1681 not anymore.)
if no other article elements have been mentioned, yet. (Previously they were `div` elements and the now-`header` element preceding them was then also a `div`. But since #1681 not anymore.)
HTML and Bootstrap updates
HTML, Bootstrap and Icons have to be updated together. Otherwise, either one will make the page look broken.
This is a followup from #1678