New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Google Fonts link element #1806

Merged

das-g merged 1 commit into DjangoGirls:master from thibaudcolas:google-fonts-simplify

Oct 8, 2023

Contributor

thibaudcolas commented Oct 8, 2023 •

edited

Loading

Simplifies the link element used for Google Fonts, so it’s easier for beginners to follow:

Its attributes should use the same quote style as other elements.
rel="stylesheet" should come first, to match other link elements.
No need for a protocol-relative URL, we can load the HTTPS version everywhere.
type="text/css" does nothing, it can be removed.


          Swap the order of href and rel for Google Fonts loading

5c3a5a9

das-g approved these changes

View reviewed changes

das-g merged commit c3588ff into DjangoGirls:master

1 check passed

Member

das-g commented Oct 8, 2023

Thank you!

thibaudcolas deleted the google-fonts-simplify branch

October 8, 2023 14:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet