Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes (broken links, missing images) #1830

Merged
merged 3 commits into from
May 18, 2024
Merged

Minor fixes (broken links, missing images) #1830

merged 3 commits into from
May 18, 2024

Conversation

kerhac
Copy link
Contributor

@kerhac kerhac commented Apr 27, 2024

I have found some minor issues and fixed them. First I noticed the contributing link in the German translation was running into a 404. Then I ran linkchecker to find the rest.

Changes in this pull request:

  • Add missing images taken from English translation
    This will add images which are reference to in the markdown files but
    are not present. The files are copies from the English translation. I
    would guess it's better to have English pictures than none.
  • Fix broken links due to html reference
    This will replace the wrong reference to .html files with .md files.
    The static page generator will take care of correctly replacing the file
    extensions while generating the page.
  • Fix broken links in installation documentation
  • Fix link to CONTRIBUTING
    The contributing guidelines are located in the main README.md and not in
    a separate file. This will align the German translation with the English
    one.

@ekohl
Copy link
Collaborator

ekohl commented May 18, 2024

I merged a PR that introduced a merge conflict. Could you update it?

The contributing guidelines are located in the main README.md and not in
a separate file. This will align the German translation with the English
one.
This will replace the wrong reference to `.html` files with `.md` files.
The static page generator will take care of correctly replacing the file
extensions while generating the page.
This will add images which are reference to in the markdown files but
are not present. The files are copies from the English translation. I
would guess it's better to have English pictures than none.
@kerhac
Copy link
Contributor Author

kerhac commented May 18, 2024

I have rebase onto master and dropped the commit fc3748a Fix broken links in installation documentation since the whole text block has been removed in 2e46145.

@das-g das-g merged commit fed9d66 into DjangoGirls:master May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants