Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #302 -- Added .pyc files to gitignore #303

Merged
merged 1 commit into from
Mar 29, 2015

Conversation

MarkusH
Copy link
Contributor

@MarkusH MarkusH commented Mar 29, 2015

Thanks @antonagestam for the report

@aniav
Copy link
Member

aniav commented Mar 29, 2015

I am really not sure we need to add this in this specific tutorial where we work on python 3. We had a talk about it in #291. Can someone else give their opinion on it? @bmispelon maybe?

@bmispelon
Copy link
Contributor

I agree that this should not be necessary with Python3 but I've seen it happen a few times now and I guess it doesn't cost us much to put it in the .gitignore anyway.

While we're there, we might as well add .pyo files too (I'm not sure how those get generated but I've seen them before in some cases).

Thanks Anton Agestam for the report
@aniav
Copy link
Member

aniav commented Mar 29, 2015

Ok, seems legit. I was wondering if this wouldn't make the thing more complicated instead of easier. But if you say it's ok I am also ok with it! :)

@MarkusH
Copy link
Contributor Author

MarkusH commented Mar 29, 2015

I haven't seen anybody asking about the content of that file, tbh. It's mostly literally copied and pasted into their code base.

@bmispelon
Copy link
Contributor

It's been my experience as well. Especially in the deploy chapter, people just copy/paste without much thinking (which sucks but it's another issue altogether).

I say :shipit: :)

bmispelon added a commit that referenced this pull request Mar 29, 2015
Fixed #302 -- Added .pyc files to gitignore
@bmispelon bmispelon merged commit afd9865 into DjangoGirls:master Mar 29, 2015
@bmispelon
Copy link
Contributor

Danke! 🐌

@MarkusH MarkusH deleted the ticket302 branch March 29, 2015 17:39
@aniav
Copy link
Member

aniav commented Mar 29, 2015

🐈 🐅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants