Use links to merge request diff view #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djuuu
force-pushed
the
fix/14-link-to-merge-request-diff-by-commit
branch
3 times, most recently
from
9140d5e to
b145273
Compare
Commit links in merge request descriptions are generated by Gitlab when it detects SHA-1 strings matching existing commits. Ex: 01234567ab -> https://gitlab.com/my/project/-/commit/01234567ab These links have not direct link to a merge request. When commenting on them, comments might be lost at rebase. Linking to the diff view, focused on a given commit, is better : https://gitlab.com/my/project/-/merge_requests/123/diffs?commit_id=0123456789abcdef0123456789abcdef0123456
Djuuu
force-pushed
the
fix/14-link-to-merge-request-diff-by-commit
branch
from
4ad3824 to
1d98624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit links in merge request descriptions are generated by Gitlab when it detects SHA-1 strings matching existing commits. Ex:
01234567ab -> https://gitlab.com/my/project/-/commit/01234567ab
These links have not direct link to a merge request. When commenting on them, comments might be lost at rebase.
Linking to the diff view, focused on a given commit, is better : https://gitlab.com/my/project/-/merge_requests/123/diffs?commit_id=0123456789abcdef0123456789abcdef0123456
Fixes #14