fixed the radius of `draw_cylinder_ab'. fixes #40

DmitriySalnikov · Mar 6, 2024 · 94c1390 · 94c1390
1 parent ba3056e
commit 94c1390
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/examples_dd3d/DebugDrawDemoScene.gd b/examples_dd3d/DebugDrawDemoScene.gd
@@ -160,7 +160,7 @@ func main_update(delta: float) -> void:
 	# Cylinders
 	DebugDraw3D.draw_cylinder($Cylinders/Cylinder1.global_transform, Color.CRIMSON)
 	DebugDraw3D.draw_cylinder(Transform3D(Basis.IDENTITY.scaled(Vector3(1,2,1)), $Cylinders/Cylinder2.global_position), Color.RED)
-	DebugDraw3D.draw_cylinder_ab($"Cylinders/Cylinder3/1".global_position, $"Cylinders/Cylinder3/2".global_position, 0.35)
+	DebugDraw3D.draw_cylinder_ab($"Cylinders/Cylinder3/1".global_position, $"Cylinders/Cylinder3/2".global_position, 0.7)
 
 	# Boxes
 	DebugDraw3D.draw_box_xf($Boxes/Box1.global_transform, Color.MEDIUM_PURPLE)

diff --git a/src/3d/debug_draw_3d.cpp b/src/3d/debug_draw_3d.cpp
@@ -610,10 +610,9 @@ void DebugDraw3D::draw_cylinder_ab(const Vector3 &a, const Vector3 &b, const rea
 	// TODO maybe someone knows a better way to solve it?
 	Vector3 diff = b - a;
 	real_t len = diff.length();
-	real_t diameter = radius * 2;
 	Vector3 half_center = diff.normalized() * len * .5f;
 	Vector3 up = get_up_vector(half_center);
-	Transform3D t = Transform3D(Basis().looking_at(half_center, up).scaled_local(Vector3(diameter, diameter, len)), a + half_center);
+	Transform3D t = Transform3D(Basis().looking_at(half_center, up).scaled_local(Vector3(radius, radius, len)), a + half_center);
 
 	LOCK_GUARD(datalock);
 	auto scfg = scoped_config_for_current_thread();