Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Statically link libgcc and libstdc++ on linux #45

Closed
goatchurchprime opened this issue May 26, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@goatchurchprime
Copy link

Feature description

This library doesn't work under nixos due to the libstdc++ library not being statically linked.

There might be similar portability issues to other linux distros.

image

This was noted for the webrtc plugin: godotengine/webrtc-native#110

Implementation Ideas

The fix was a couple of settings in the SConstruct file to force static linking to the libstdc++ libraries.
godotengine/webrtc-native@1de32aa

@goatchurchprime goatchurchprime added the enhancement New feature or request label May 26, 2024
@DmitriySalnikov
Copy link
Owner

There might be similar portability issues to other linux distros.

Sure.
I have already faced another problem. My library refused to run on Ubuntu 20 if the library was built on Ubuntu 22. I found these build flags, but as far as I remember it still didn't solve the problem, so I just rolled back the Ubuntu version inside Github CI and everything worked.

You can test these changes here

😔
fkP4hntFE7

@DmitriySalnikov
Copy link
Owner

@goatchurchprime so is the library working now?

@goatchurchprime
Copy link
Author

Confirmed that April version does not work, and this May version does work.
I think @Nitwel had sent me a fixed version that he compiled himself, it worked, and then I completely forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants