-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web/WASM Support #23
Add Web/WASM Support #23
Conversation
46e9f1d
to
9322e9f
Compare
Hey, happy to update the project and squash the commits.
I can revert those changes if you would rather add them in a separate commit or PR. I mostly added them for testing. I think I only added the wasm files so I can manually remove the other updates as well. If you have any other suggestions or comments let me know.
Think it's a good idea to submit it to the |
Why not? They have recommendations and you can just do a fork and PR. Everything else is fine. I was able to build locally and run. Thanks! |
Sounds good. thanks for reviewing the PR. I'll make a PR to the godot repo after reading over those recommendations. Oh, I'm also working on adding an automated github pages build for the project (upload the demo project to github pages for the repo). Would you be interested in adding that to this project as well? |
Do you mean some kind of documentation generation or just auto-uploading and updating the demo project on github pages? |
Auto generating the site and uploading to GitHub pages. I have it working in my repo right now here - https://nickmaltbie.com/godot_debug_draw_3d/ Auto generating documentation could be added as well but I always like including demos of my libraries that people can checkout from the github page. I want to include these demos for some godot projects I am working on and found your repo while researching. |
Hey, I'm learning godot and found your repo awesome @DmitriySalnikov
I'm trying to setup gdexport for web and ran across your issue #19 and I have been able to build it locally by adding the PThresds flags to enable shared memory in the export. And updating the version of emsdk to
3.1.46
to be in line with v4.1.1-stable of godot's web export. Thought I should share how I got it to build and export locally on my machine.I've testing building it with v4.1.1-stable of godot and was able to compile and run on my local machine. Checkout my web build branch to see an example - https://github.com/nicholas-maltbie/godot_debug_draw_3d/tree/nickmaltbie/web-build
Also, I only have had it work with chromium-based browsers (Edge in the photo), seems like there is a note about it in the Export for Web pages on the docs.
If you have any questions or suggestions for the PR let me know.