Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ios binaries #36

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

emirthab
Copy link
Contributor

Tried on iPhone 11 device. Works fine.

RPReplay_Final1708129760.mp4

@DmitriySalnikov
Copy link
Owner

That's good, but I don't need only binaries.
It would be cool if you updated the CI scripts and tested them.

https://github.com/DmitriySalnikov/godot_debug_draw_3d/blob/master/.github/workflows/gdextension_build.yml
https://github.com/DmitriySalnikov/godot_debug_draw_3d/blob/master/.github/actions/compile_gdextension/action.yml

Most likely, it is enough to update the gdextension_build.yml and everything will work, but I won't be able to test it myself.

@DmitriySalnikov
Copy link
Owner

Adding -S to the strip will probably help. Maybe it's not even worth creating an elif. You can check it locally for macOS and iOS on your mac before pushing.

Also you need to add ios-gdextension to collect-gdextension: needs:.

@emirthab
Copy link
Contributor Author

It looks like it happened.

Ekran Resmi 2024-02-17 05 46 32

@DmitriySalnikov
Copy link
Owner

For android, compile_gdextension uses the argument additional_enabled_dd3d: false in order not to much increase the size of the downloaded binaries.
In the case of ios, the size does not increase so much, so it would be more correct to add ios.template_release.forced_dd3d to .gdextension.

And it is advisable to 'squash/fixup' commits.

@DmitriySalnikov DmitriySalnikov merged commit 0cbafaa into DmitriySalnikov:master Feb 17, 2024
22 checks passed
@DmitriySalnikov
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants