Add support for ActiveRecord::Relation#load_async method. #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @DmitryTsepelev
A few days ago I tested how the gem works with
ActiveRecord::Relation#load_async
and as expected it didn't work because this method performs database queries outside of the main thread. But instantiation of models is done in the main thread. So I've created a patch forActiveRecord::FutureResult
class (it's used to get results from such queries).I had to change
DatabaseCleaner
configurations becauseload_async
inside transactions executes queries in the main thread.Would like to know your opinion about this changes. Thank you!