-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add otkafka processor #134
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
14f102b
feat: add otkafka/processor
GGXXLL c035fd6
Merge remote-tracking branch 'up/master' into otkafka-processor
GGXXLL 2f7d119
Update go.yml
GGXXLL a88f74b
feat: add otkafka processor
GGXXLL 62e692f
Merge remote-tracking branch 'up/master'
GGXXLL 8990ae3
Merge branch 'master' into otkafka-processor
GGXXLL ab4c6c9
test: use wait group for graceful shutdown
GGXXLL 46b9fb5
test: add lock for data
GGXXLL e303d05
refactor: rename some variables and modify comment
GGXXLL 532bcbd
fix: hound check
GGXXLL 9a3ab67
chore: update go.mod kafka-go
GGXXLL e591f09
refactor: restructure and fix some bug
GGXXLL bd8393c
fix: single Handler's message missing commit
GGXXLL 9390ff1
Merge branch 'master' into otkafka-processor
Reasno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ on: | |
| branches: | ||
| - master | ||
| pull_request: | ||
| workflow_dispatch: | ||
| jobs: | ||
| build: | ||
| strategy: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package processor | ||
|
|
||
| import "time" | ||
|
|
||
| // Info the info of BatchHandler. | ||
| // | ||
| // Note: | ||
| // If sequence is necessary, make sure that per worker count is one. | ||
| // Multiple goroutines cannot guarantee the order in which data is processed. | ||
| type Info struct { | ||
| // used to get reader from otkafka.ReaderMaker. | ||
| // default: "default" | ||
| Name string | ||
| // reader workers count. | ||
| // default: 1 | ||
| ReadWorker int | ||
| // batch workers count. | ||
| // default: 1 | ||
| BatchWorker int | ||
| // data size for batch processing. | ||
| // default: 1 | ||
| BatchSize int | ||
| // handler workers count. | ||
| HandleWorker int | ||
| // the size of the data channel. | ||
| // default: 100 | ||
| ChanSize int | ||
| // run the batchFunc automatically at specified intervals, avoid not executing without reaching BatchSize | ||
| // default: 30s | ||
| AutoBatchInterval time.Duration | ||
| } | ||
|
|
||
| func (i *Info) name() string { | ||
| if i.Name == "" { | ||
| return "default" | ||
| } | ||
| return i.Name | ||
| } | ||
|
|
||
| func (i *Info) readWorker() int { | ||
| if i.ReadWorker <= 0 { | ||
| return 1 | ||
| } | ||
| return i.ReadWorker | ||
| } | ||
|
|
||
| func (i *Info) batchWorker() int { | ||
| if i.BatchWorker <= 0 { | ||
| return 1 | ||
| } | ||
| return i.BatchWorker | ||
| } | ||
|
|
||
| func (i *Info) batchSize() int { | ||
| if i.BatchSize <= 0 { | ||
| return 1 | ||
| } | ||
| return i.BatchSize | ||
| } | ||
|
|
||
| func (i *Info) handleWorker() int { | ||
| if i.HandleWorker <= 0 { | ||
| return 1 | ||
| } | ||
| return i.HandleWorker | ||
| } | ||
|
|
||
| func (i *Info) chanSize() int { | ||
| if i.ChanSize <= 0 { | ||
| return 100 | ||
| } | ||
| return i.ChanSize | ||
| } | ||
|
|
||
| func (i *Info) autoBatchInterval() time.Duration { | ||
| if i.AutoBatchInterval < 10 { | ||
| return 30 * time.Second | ||
| } | ||
| return i.AutoBatchInterval | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package processor | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestInfo(t *testing.T) { | ||
| i := Info{ | ||
| Name: "", | ||
| ReadWorker: 0, | ||
| BatchWorker: 0, | ||
| BatchSize: 0, | ||
| HandleWorker: 0, | ||
| ChanSize: 0, | ||
| } | ||
| assert.Equal(t, "default", i.name()) | ||
| assert.Equal(t, 1, i.readWorker()) | ||
| assert.Equal(t, 1, i.batchWorker()) | ||
| assert.Equal(t, 1, i.batchSize()) | ||
| assert.Equal(t, 1, i.handleWorker()) | ||
| assert.Equal(t, 100, i.chanSize()) | ||
| assert.Equal(t, 30*time.Second, i.autoBatchInterval()) | ||
|
|
||
| j := Info{ | ||
| Name: "test", | ||
| ReadWorker: 2, | ||
| BatchWorker: 2, | ||
| BatchSize: 10, | ||
| HandleWorker: 2, | ||
| ChanSize: 10, | ||
| AutoBatchInterval: 10 * time.Second, | ||
| } | ||
| assert.Equal(t, j.Name, j.name()) | ||
| assert.Equal(t, j.ReadWorker, j.readWorker()) | ||
| assert.Equal(t, j.BatchWorker, j.batchWorker()) | ||
| assert.Equal(t, j.BatchSize, j.batchSize()) | ||
| assert.Equal(t, j.HandleWorker, j.handleWorker()) | ||
| assert.Equal(t, j.ChanSize, j.chanSize()) | ||
| assert.Equal(t, j.AutoBatchInterval, j.autoBatchInterval()) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个用私有成员变量，公开方法更好吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的