Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(srvhttp): RequestDurationSeconds shouldn't panic when missing labels #207

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Oct 21, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #207 (c61c7ab) into master (ab0fffc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   82.14%   82.17%   +0.03%     
==========================================
  Files          90       90              
  Lines        3445     3451       +6     
==========================================
+ Hits         2830     2836       +6     
  Misses        460      460              
  Partials      155      155              
Impacted Files Coverage Δ
srvhttp/metrics.go 83.78% <100.00%> (+3.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0fffc...c61c7ab. Read the comment docs.

@Reasno Reasno merged commit e72a19d into master Oct 21, 2021
@Reasno Reasno deleted the srvhttp branch October 21, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants