refactor(cron): replace cron implementation. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: most Observe() methods now take a time.Duration instead of float64.
This PR replaces the cron implementation. BREAKING CHANGE: the new cron package github/DoNewsCode/core/cron is not compatible with github.com/robfig/cron/v3. See examples for how to migrate.
# Conflicts: # cronopts/jobs/universal.go
This PR replaces the cron implementation. BREAKING CHANGE: the new cron package github/DoNewsCode/core/cron is not compatible with github.com/robfig/cron/v3. See examples for how to migrate.
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 82.91% 83.50% +0.58%
==========================================
Files 100 102 +2
Lines 3618 3794 +176
==========================================
+ Hits 3000 3168 +168
- Misses 456 461 +5
- Partials 162 165 +3
Continue to review full report at Codecov.
|
GGXXLL
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the cron implementation. The API in the new package enforces context passing and error
propagation, and consequently enables better logging, metrics, and tracing support.
BREAKING CHANGE: the new cron package github/DoNewsCode/core/cron is not compatible with github.com/robfig/cron/v3. See examples for how to migrate. The contract.Container API surface is reduced.