Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle 7 incompatibility #23

Closed
brazenvoid opened this issue Oct 9, 2020 · 7 comments
Closed

Guzzle 7 incompatibility #23

brazenvoid opened this issue Oct 9, 2020 · 7 comments

Comments

@brazenvoid
Copy link

Laravel 8 requires Guzzle 7 but docraptor doesn't support it.

@brazenvoid
Copy link
Author

I tried by moving the source to main project and running with Guzzle 7 and it worked fine.

Please update the dependency requirement.

@airdrummingfool
Copy link

I have created a PR (#24) that adds support for Guzzle 7. Until it is merged, you can use it by making the following changes to composer.json:

Add a vcs repository entry for my fork:

    "repositories": [
      {
        "type": "vcs",
        "url": "https://github.com/airdrummingfool/docraptor-php"
      }
    ],

switch the docraptor require to use my guzzle-7 branch (must include dev- prefix):

"docraptor/docraptor": "dev-guzzle-7",

Use at your own risk! I will delete the fork after my PR is merged.

@Rodeoclash
Copy link

I've thumbed up everything I can in this PR but also feel the need to add a comment. I'd love for this to be merged!

jfrabaute added a commit to jfrabaute/docraptor-php that referenced this issue May 2, 2021
Temp fix before upstream is fixed:
DocRaptor#23
DocRaptor#24
jfrabaute added a commit to jfrabaute/docraptor-php that referenced this issue May 2, 2021
Temp fix before upstream is fixed:
DocRaptor#23
DocRaptor#24
@Rodeoclash
Copy link

It's been ~5 months since this issue was raised and a PR provided that hasn't been merged. Is it safe to assume that we shouldn't expect further updates to the DocRaptor PHP library and instead should look at interfacing with the endpoints directly?

@SteelWagstaff
Copy link

@Rodeoclash see recent response on this issue from @jason-o-matic here: #24 (comment)

@christianl-das
Copy link

There is now an additional issue with the use of build_query(). That function no longer exists in the most recent versions of Guzzle. It has been replaced by Build::query().

@esquivalient
Copy link
Contributor

I released version 3.0 today. It should solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants