Fixed search bar issue on Chrome and Safari #3165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses the safari cursor bug for navbar search
Fixing Chrome bug for navbar search bar :focus
| @@ -21,6 +21,12 @@ nav { | |||
| position: relative; | |||
| height: 100%; | |||
| } | |||
| form { | |||
|
Thanks, it works well for me. |
|
+1 can we merge this? |
|
Actually this issue might be duplicated with : #3161 which is already merged (more code is changed as part of this PR though). |
|
@gugerard The original issue mentions a cursor bug in Safari and this addresses that as well as the Chrome fix |
|
There is duplicated code in this pull request. Take a look at the whole file, your form and input-field styles are duplicates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #3161
This fixes the bug in Chrome and Safari (previous commit c129dc1 solves only Chrome issue)